553808 - mochitest-chrome: test_tmpl_errors.xul causes 3 "ASSERTION: This is unsafe! Fix the caller!: 'Error', file .../nsEventDispatcher.cpp, line 514" in a row

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Serge Gautherie (:sgautherie)]

FF and SM 'mochitest-other' builds report this error.

Examples:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269087450.1269089074.27737.gz&fulltext=1
Linux mozilla-central debug test mochitest-other on 2010/03/20 05:17:30
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1269084827.1269088184.24785.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2010/03/20 04:33:47

This assertion happens 3 times.
It might also happen on other tests (builds): I didn't check.

I didn't copy the stack, because I don't know what is interesting in it wrt
this assertion...

***

This assertion was added initially in:
"You are not authorized to access bug #531176"!
http://hg.mozilla.org/mozilla-central/rev/e58c2ef1d65b

Comment 1

[Johnny Stenback (:jst)]

Olli, can you have a look at this? If you find out this doesn't need to block, I'm fine with unblocking on this.

Comment 2

[Jonathan Kew [:jfkthame]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1273906124.1273908466.7724.gz
Rev3 Fedora 12x64 mozilla-central debug test mochitest-other on 2010/05/14 23:48:44
s: talos-r3-fed64-010

###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error', file /builds/slave/mozilla-central-linux64-debug/build/content/events/src/nsEventDispatcher.cpp, line 514

Various other assertions follow, but this is the first one that shows up, hence noting it here.

Comment 3

[Johnny Stenback (:jst)]

Olli, any idea when you might get to this?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Serge, have you still seen the assertion?
At least some of the cases when "This is unsafe!" assertion fired have been
fixed after this was filed.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

So has anyone seen this one for awhile?

Comment 6

[Martijn Wargers (dead)]

I was just seeing this on http://apps.facebook.com/wildones/ (from bug 588591).

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Martijn, are you sure it is the same as this one?
Just having the assertion doesn't mean it is the same bug.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

The assertion in bug 588591 is caused by something else.

Comment 9

[Martijn Wargers (dead)]

Sorry, I thought it was about seeing this assertion.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Marking this WFM, since apparently this hasn't happened with mochitests for awhile.

Comment 11

[Serge Gautherie (:sgautherie)]

Comment 0 case happens still/again:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1283750333.1283752120.24940.gz&fulltext=1
Rev3 Fedora 12 mozilla-central debug test mochitest-other on 2010/09/05 22:18:53
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1283747217.1283748852.11163.gz&fulltext=1
Rev3 Fedora 12x64 mozilla-central debug test mochitest-other on 2010/09/05 21:26:57
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1283745094.1283746880.4007.gz&fulltext=1
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test mochitest-other on 2010/09/05 20:51:34
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1283745179.1283746983.4325.gz&fulltext=1
Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test mochitest-other on 2010/09/05 20:52:59
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1283746297.1283748079.8435.gz&fulltext=1
WINNT 5.2 mozilla-central debug test mochitest-other on 2010/09/05 21:11:37
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1283743505.1283745870.31878.gz&fulltext=1
Linux comm-central-trunk debug test mochitest-other on 2010/09/05 20:25:05
{
...
243 INFO TEST-PASS | chrome://mochikit/content/chrome/content/xul/templates/tests/chrome/test_tmpl_errors.xul | logged message Error parsing template: <triple> should have at least one variable as a subject or object - "Error parsing template: <triple> should have at least one variable as a subject or object" should equal "Error parsing template: <triple> should have at least one variable as a subject or object"
###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error', file /builds/slave/mozilla-central-linux-debug/build/content/events/src/nsEventDispatcher.cpp, line 514
...
###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error', file /builds/slave/mozilla-central-linux-debug/build/content/events/src/nsEventDispatcher.cpp, line 514
...
###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error', file /builds/slave/mozilla-central-linux-debug/build/content/events/src/nsEventDispatcher.cpp, line 514
...
244 INFO TEST-PASS | chrome://mochikit/content/chrome/content/xul/templates/tests/chrome/test_tmpl_errors.xul | logged message Error parsing template: XPath expression in query could not be parsed - "Error parsing template: XPath expression in query could not be parsed" should equal "Error parsing template: XPath expression in query could not be parsed"
}

Comment 12

[Serge Gautherie (:sgautherie)]

http://mxr.mozilla.org/mozilla-central/source/content/xul/templates/tests/chrome/test_tmpl_errors.xul
{
188 // neither triple subject or object variable are bound
189 {
190   pre: function(template) { var triple = $("triple"); triple.setAttribute("subject", "blah");
191                             triple.setAttribute("object", "blah"); },
192   error: "Error parsing template: <triple> should have at least one variable as a subject or object",
193   post: function() { var triple = $("triple"); triple.setAttribute("subject", "?uri");
194                      triple.setAttribute("object", "?uri") }
195 },
196 
197 // could not parse xml query expression
198 {
199   firstXMLTest: true,
200   pre: function(template) { $("query").setAttribute("expr", "something()"); },
201   error: "Error parsing template: XPath expression in query could not be parsed",
202   post: function() { }
203 },
}

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Neil, are you the right person to take this?

Comment 14

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/3e08f8844f87

Comment 15

[Serge Gautherie (:sgautherie)]

V.Fixed, per
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1288109189.1288111299.2425.gz&fulltext=1
Rev3 Fedora 12 mozilla-central debug test mochitest-other on 2010/10/26 09:06:29