Closed Bug 554015 Opened 11 years ago Closed 10 years ago

reorder fulltext columns so body is the 0th column for disk-space savings


(MailNews Core :: Database, defect)

Not set


(Not tracked)

Thunderbird 10.0


(Reporter: asuth, Assigned: protz)


(Keywords: perf, Whiteboard: [gloda key])


(1 file, 1 obsolete file)

Per, the doclist encoding for terms encountered in the 0th column is specialized.  This would save us 2 bytes per distinct term per document in the body.  It would also cost us 2 bytes per term per document in the subject, but since the subject should generally be much shorter than the body, the choice is clear.
Attached patch Patch v1 (obsolete) — Splinter Review
This seems to make test_msg_search.js fail (the non-failing tests might by commented out). Any idea as to why this may be failing will be highly appreciated :-).
Assignee: bugmail → jonathan.protzenko
Attachment #551971 - Flags: feedback?(bugmail)
Attached patch Patch v2Splinter Review
Ok, found what I missed. I fixed the comment if we ever want to swap the two again ;-)
Attachment #551971 - Attachment is obsolete: true
Attachment #552003 - Flags: review?(bugmail)
Attachment #551971 - Flags: feedback?(bugmail)
Comment on attachment 552003 [details] [diff] [review]
Patch v2

Ah yeah, the ranker function was a more recent addition.

Looks great, thanks for taking care of this!
Attachment #552003 - Flags: review?(bugmail) → review+
I suspect you are already aware, but just to make sure, we cannot land this unless we also land a patch that bumps the schema version, so do keep it in your queue.  I think it's okay if we bump the schema multiple times on comm-central as long as it doesn't get shifted to comm-aurora in between, so let's wait to do that until just after we make the next cut from comm-central to comm-aurora which should be happening soon.
Keywords: perf
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
You need to log in before you can comment on or make changes to this bug.