switch mozilla-central Linux builds to use -gdwarf-2 instead of -gstabs

RESOLVED FIXED

Status

Release Engineering
General
P3
normal
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

After the Breakpad update in bug 548113, we should now be able to dump DWARF symbols on Linux. We should switch from stabs because we'll get better symbols in some cases, and it will also allow us to use -fomit-frame-pointer.
Depends on: 554019

Updated

8 years ago
Assignee: nobody → ccooper
Priority: -- → P3

Updated

8 years ago
Blocks: 554364
Depends on: 554028
Created attachment 434599 [details] [diff] [review]
s/stabs[+]/dwarf-2/

Stealing this bug, another sed-generated patch, via:
find . -name "mozconfig" | xargs grep -l MOZ_DEBUG_SYMBOLS | grep -v "1.9" | grep -v lorentz | grep -v "seamonkey/" | grep -v thunderbird | grep linux  | xargs sed -i -e 's/stabs[+]/dwarf-2/'
Assignee: ccooper → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #434599 - Flags: review?(catlee)

Updated

8 years ago
Attachment #434599 - Flags: review?(catlee) → review+

Comment 2

8 years ago
By the way, there is also -gstabs, in js/src/configure.in.
(In reply to comment #2)
> By the way, there is also -gstabs, in js/src/configure.in.

That's in some ancient QNX block, not relevant for this discussion.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
linux64 symlinks more branches back to mozilla-central than linux does, so there were changes to mozilla-1.9.1 and 1.9.2 which may not have been intended. But we don't build symbols on linux64 for those branches ?
I didn't know that, and it was unintentional, but yeah, it's harmless since we don't have Breakpad support for Linux64 on anything but trunk currently. (Thanks for the heads up!)
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.