554024 - switch mozilla-central Linux builds to use -gdwarf-2 instead of -gstabs

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[(not currently active) Ted Mielczarek]

After the Breakpad update in bug 548113, we should now be able to dump DWARF symbols on Linux. We should switch from stabs because we'll get better symbols in some cases, and it will also allow us to use -fomit-frame-pointer.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: s/stabs[+]/dwarf-2/

Stealing this bug, another sed-generated patch, via:
find . -name "mozconfig" | xargs grep -l MOZ_DEBUG_SYMBOLS | grep -v "1.9" | grep -v lorentz | grep -v "seamonkey/" | grep -v thunderbird | grep linux  | xargs sed -i -e 's/stabs[+]/dwarf-2/'

Comment 2

[Jim Blandy :jimb]

By the way, there is also -gstabs, in js/src/configure.in.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 434599 [details] [diff] [review]
s/stabs[+]/dwarf-2/

Landed:
http://hg.mozilla.org/build/buildbot-configs/rev/78147c4334ba

Comment 4

[(not currently active) Ted Mielczarek]

(In reply to comment #2)
> By the way, there is also -gstabs, in js/src/configure.in.

That's in some ancient QNX block, not relevant for this discussion.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

linux64 symlinks more branches back to mozilla-central than linux does, so there were changes to mozilla-1.9.1 and 1.9.2 which may not have been intended. But we don't build symbols on linux64 for those branches ?

Comment 6

[(not currently active) Ted Mielczarek]

I didn't know that, and it was unintentional, but yeah, it's harmless since we don't have Breakpad support for Linux64 on anything but trunk currently. (Thanks for the heads up!)