554046 - Land OOPP strings on the 1.9.2 branch (optional for now)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

We need to land the OOPP strings on the 1.9.2 branch. I have backported everything to Lorentz. I will attach the current diff between 1.9.2 and Lorentz. We need to land these strings on 1.9.2, and make compare-locales (or whatever verification system we're using now) note that the strings are optional, at least now, and provide English backup strings.

Comment 1

[Benjamin Smedberg]

Attachment: String changes, 1.9.2 -> Lorentz

Comment 2

[Axel Hecht [:Pike]]

The way to make 1.9.2 ignore those strings is to adjust filter.py, http://mxr.mozilla.org/mozilla1.9.2/source/browser/locales/filter.py.

Comment 3

[Mark Banner (:standard8)]

So given the toolkit changes, I guess Thunderbird will need to do the same thing.

If we can I'd like to base the changes to mail/locales/filter.py on the browser/locales/filter.py changes - but have time to land it before you guys land the strings.

I'm not sure what you guys have got planned for timescales for landing, but we're meant to be starting a string freeze tomorrow for a week, so it would be nice not to confuse our locales in that time.

Comment 4

[Benjamin Smedberg]

Attachment: filter.py changes, rev. 1

Here are the filter.py changes. I'd like to land these and the strings ASAP so that localizations can start translations for beta.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 433932 [details] [diff] [review]
String changes, 1.9.2 -> Lorentz

a=beltzner

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 434075 [details] [diff] [review]
filter.py changes, rev. 1

a=beltzner

Comment 7

[Axel Hecht [:Pike]]

Mark, I'm confused by the setups in thunderbird land. In my configs, I see the tb31x tree to be against 1.9.2, in the buildbot-configs on the other hand, that seems to be against 1.9.1.

I'd guess we want to modify the filter.py on comm-central?

Comment 8

[Axel Hecht [:Pike]]

Hrm, and we need this for fennec11x, aka, mobile-browser/locales/filter.py.

Comment 9

[Axel Hecht [:Pike]]

http://hg.mozilla.org/mobile-browser/rev/1d2e04ec4b5f is for mobile.

Comment 10

[Axel Hecht [:Pike]]

http://hg.mozilla.org/comm-central/rev/58494ac482bf is for Thunderbird.

Comment 11

[Benjamin Smedberg]

Going to call this FIXED, and use bug 554214 for the English fallback strings (patch already posted).