Closed Bug 554046 Opened 10 years ago Closed 10 years ago

Land OOPP strings on the 1.9.2 branch (optional for now)

Categories

(Firefox Build System :: General, defect)

x86
Linux
defect
Not set

Tracking

(status1.9.2 .4-fixed)

RESOLVED FIXED
Tracking Status
status1.9.2 --- .4-fixed

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(2 files)

We need to land the OOPP strings on the 1.9.2 branch. I have backported everything to Lorentz. I will attach the current diff between 1.9.2 and Lorentz. We need to land these strings on 1.9.2, and make compare-locales (or whatever verification system we're using now) note that the strings are optional, at least now, and provide English backup strings.
The way to make 1.9.2 ignore those strings is to adjust filter.py, http://mxr.mozilla.org/mozilla1.9.2/source/browser/locales/filter.py.
So given the toolkit changes, I guess Thunderbird will need to do the same thing.

If we can I'd like to base the changes to mail/locales/filter.py on the browser/locales/filter.py changes - but have time to land it before you guys land the strings.

I'm not sure what you guys have got planned for timescales for landing, but we're meant to be starting a string freeze tomorrow for a week, so it would be nice not to confuse our locales in that time.
Here are the filter.py changes. I'd like to land these and the strings ASAP so that localizations can start translations for beta.
Attachment #434075 - Flags: review?(l10n)
Attachment #434075 - Flags: review?(l10n) → review+
Attachment #433932 - Flags: approval1.9.2.3?
Attachment #434075 - Flags: approval1.9.2.3?
Comment on attachment 433932 [details] [diff] [review]
String changes, 1.9.2 -> Lorentz

a=beltzner
Attachment #433932 - Flags: approval1.9.2.3? → approval1.9.2.3+
Comment on attachment 434075 [details] [diff] [review]
filter.py changes, rev. 1

a=beltzner
Attachment #434075 - Flags: approval1.9.2.3? → approval1.9.2.3+
Mark, I'm confused by the setups in thunderbird land. In my configs, I see the tb31x tree to be against 1.9.2, in the buildbot-configs on the other hand, that seems to be against 1.9.1.

I'd guess we want to modify the filter.py on comm-central?
Hrm, and we need this for fennec11x, aka, mobile-browser/locales/filter.py.
Blocks: 554214
Going to call this FIXED, and use bug 554214 for the English fallback strings (patch already posted).
Assignee: dolske → benjamin
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.