554072 - CSS Resize horizontal and vertical resize slightly in other directions

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, minor)

Description

[Wesley Johnston (:wesj)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100322 Minefield/3.7a4pre
Build Identifier: 

Setting -moz-resize: horizontal allows you to slightly change the size in the vertical direction (and similarly for vertical). Every time you click on the resizer you can add a few pixels in the orthogoal direction, eventually adding a bunch if you want. I'll attach a test-case. Comes from the CSS3.info page, hacking in the moz prefixes.

Reproducible: Always

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Testcase from css3.info

Testcase

Comment 2

[Neil Deakin]

Attachment: patch

The issue here is that the size is retrieved using the border-box size but set using the content-box size. Instead, we get the right size and account for the border and padding.

Also, mMouseDownRect should be in device pixels, not css pixels.

Comment 3

[Neil Deakin]

Hmmm. some tabs in that patch. I'll convert to spaces.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 434308 [details] [diff] [review]
patch

+          nsRect rect = frameToResize->GetScreenRectInAppUnits();
+		  switch(frameToResize->GetStylePosition()->mBoxSizing) {
+			case NS_STYLE_BOX_SIZING_CONTENT:
+			  rect -= frameToResize->GetUsedPadding();
+			case NS_STYLE_BOX_SIZING_PADDING:
+			  rect -= frameToResize->GetUsedBorder();
+			default:
+			  break;
+          }

Fix indent (I guess that's what you just said). Also, space after 'switch'

Comment 5

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/224fcc978555