Closed Bug 554072 Opened 10 years ago Closed 10 years ago

CSS Resize horizontal and vertical resize slightly in other directions

Categories

(Core :: CSS Parsing and Computation, defect, minor)

x86
Windows 7
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: wesj, Assigned: enndeakin)

Details

(Keywords: testcase)

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100322 Minefield/3.7a4pre
Build Identifier: 

Setting -moz-resize: horizontal allows you to slightly change the size in the vertical direction (and similarly for vertical). Every time you click on the resizer you can add a few pixels in the orthogoal direction, eventually adding a bunch if you want. I'll attach a test-case. Comes from the CSS3.info page, hacking in the moz prefixes.

Reproducible: Always
Testcase
Component: DOM: CSS Object Model → Style System (CSS)
QA Contact: general → style-system
Status: UNCONFIRMED → NEW
blocking2.0: --- → ?
Ever confirmed: true
Attached patch patchSplinter Review
The issue here is that the size is retrieved using the border-box size but set using the content-box size. Instead, we get the right size and account for the border and padding.

Also, mMouseDownRect should be in device pixels, not css pixels.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #434308 - Flags: review?(roc)
Hmmm. some tabs in that patch. I'll convert to spaces.
Comment on attachment 434308 [details] [diff] [review]
patch

+          nsRect rect = frameToResize->GetScreenRectInAppUnits();
+		  switch(frameToResize->GetStylePosition()->mBoxSizing) {
+			case NS_STYLE_BOX_SIZING_CONTENT:
+			  rect -= frameToResize->GetUsedPadding();
+			case NS_STYLE_BOX_SIZING_PADDING:
+			  rect -= frameToResize->GetUsedBorder();
+			default:
+			  break;
+          }

Fix indent (I guess that's what you just said). Also, space after 'switch'
Attachment #434308 - Flags: review?(roc) → review+
http://hg.mozilla.org/mozilla-central/rev/224fcc978555
Status: ASSIGNED → RESOLVED
blocking2.0: ? → ---
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.