[OOPP] Unimplement NPN_Status

RESOLVED FIXED in Firefox 41

Status

()

RESOLVED FIXED
9 years ago
3 years ago

People

(Reporter: bent.mozilla, Assigned: cpeterson)

Tracking

Trunk
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(2 attachments)

It's currently unimplemented and silverlight at least calls it.
(Assignee)

Comment 1

3 years ago
Created attachment 8623501 [details] [diff] [review]
remove_NPN_Status.patch

Remove NPN_Status() implementation.

When testing Netflix in a debug build of Firefox on Windows, I noticed that the Silverlight plugin calls NPN_Status("Done") continuously.. even though Firefox no longer has a proper status bar (just the HREF status bar when mousing over a link) and, when we did, web content was prohibited from setting the status bar text unless the "dom.disable_window_status_change" pref was flipped (e.g. bug 875956).

NPN_Status() is not plumbed on e10s, so Silverlight logs an endless stream of "Not yet implemented!" warnings. Rather than hook up NPN_Status() for e10s, this patch removes the useless implementation for all plugins, leaving a no-op implementation for Silverlight to call.

[NPAPI 3048] WARNING: Not yet implemented!: file c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/plugins/ipc/PluginModuleChild.cpp, line 1325
[NPAPI 3048] WARNING: Not yet implemented!: file c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/plugins/ipc/PluginModuleChild.cpp, line 1325
[NPAPI 3048] WARNING: Not yet implemented!: file c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/plugins/ipc/PluginModuleChild.cpp, line 1325
[NPAPI 3048] WARNING: Not yet implemented!: file c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/plugins/ipc/PluginModuleChild.cpp, line 1325
[NPAPI 3048] WARNING: Not yet implemented!: file c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/plugins/ipc/PluginModuleChild.cpp, line 1325
[NPAPI 3048] WARNING: Not yet implemented!: file c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/plugins/ipc/PluginModuleChild.cpp, line 1325
[NPAPI 3048] WARNING: Not yet implemented!: file c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/plugins/ipc/PluginModuleChild.cpp, line 1325
Assignee: nobody → cpeterson
Status: NEW → ASSIGNED
Attachment #8623501 - Flags: review?(joshmoz)
(Assignee)

Comment 2

3 years ago
Created attachment 8623505 [details] [diff] [review]
remove-ShowNativeContextMenu.patch

If we are revving the nsIPluginInstanceOwner interface for ShowStatus, we can remove the unused nsPluginInstanceOwner::ShowNativeContextMenu() function, too.

ShowNativeContextMenu() was unimplemented in bug 1092630, but left the following comment:

// This is no longer used, just leaving it here so we don't have to change
// the nsIPluginInstanceOwner interface.
Attachment #8623505 - Flags: review?(joshmoz)
(Assignee)

Updated

3 years ago
Summary: [OOPP] Implement NPN_Status → [OOPP] Unimplement NPN_Status

Updated

3 years ago
Attachment #8623505 - Flags: review?(joshmoz) → review+

Updated

3 years ago
Attachment #8623501 - Flags: review?(joshmoz) → review+
(Assignee)

Comment 4

3 years ago
Thanks!
https://hg.mozilla.org/mozilla-central/rev/5074afd9e8eb
https://hg.mozilla.org/mozilla-central/rev/143b1f404a45
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.