554186 - [OOPP] Unimplement NPN_Status

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

It's currently unimplemented and silverlight at least calls it.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: remove_NPN_Status.patch

Remove NPN_Status() implementation.

When testing Netflix in a debug build of Firefox on Windows, I noticed that the Silverlight plugin calls NPN_Status("Done") continuously.. even though Firefox no longer has a proper status bar (just the HREF status bar when mousing over a link) and, when we did, web content was prohibited from setting the status bar text unless the "dom.disable_window_status_change" pref was flipped (e.g. bug 875956).

NPN_Status() is not plumbed on e10s, so Silverlight logs an endless stream of "Not yet implemented!" warnings. Rather than hook up NPN_Status() for e10s, this patch removes the useless implementation for all plugins, leaving a no-op implementation for Silverlight to call.

[NPAPI 3048] WARNING: Not yet implemented!: file c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/plugins/ipc/PluginModuleChild.cpp, line 1325
[NPAPI 3048] WARNING: Not yet implemented!: file c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/plugins/ipc/PluginModuleChild.cpp, line 1325
[NPAPI 3048] WARNING: Not yet implemented!: file c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/plugins/ipc/PluginModuleChild.cpp, line 1325
[NPAPI 3048] WARNING: Not yet implemented!: file c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/plugins/ipc/PluginModuleChild.cpp, line 1325
[NPAPI 3048] WARNING: Not yet implemented!: file c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/plugins/ipc/PluginModuleChild.cpp, line 1325
[NPAPI 3048] WARNING: Not yet implemented!: file c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/plugins/ipc/PluginModuleChild.cpp, line 1325
[NPAPI 3048] WARNING: Not yet implemented!: file c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/plugins/ipc/PluginModuleChild.cpp, line 1325

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: remove-ShowNativeContextMenu.patch

If we are revving the nsIPluginInstanceOwner interface for ShowStatus, we can remove the unused nsPluginInstanceOwner::ShowNativeContextMenu() function, too.

ShowNativeContextMenu() was unimplemented in bug 1092630, but left the following comment:

// This is no longer used, just leaving it here so we don't have to change
// the nsIPluginInstanceOwner interface.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5074afd9e8eb
https://hg.mozilla.org/integration/mozilla-inbound/rev/143b1f404a45

Comment 4

[Chris Peterson [:cpeterson]]

Thanks!

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5074afd9e8eb
https://hg.mozilla.org/mozilla-central/rev/143b1f404a45