554193 - mochitest-other failed with "browser_library_middleclick.js | window made active - Got [object ChromeWindow], expected [object ChromeWindow]"

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269297885.1269299450.29179.gz
Linux mozilla-central opt test mochitest-other on 2010/03/22 15:44:45  
s: moz2-linux-slave10

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_library_middleclick.js | window made active - Got [object ChromeWindow], expected [object ChromeWindow]
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_library_middleclick.js | window made active - Got [object ChromeWindow], expected [object ChromeWindow]
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_library_middleclick.js | window made active - Got [object ChromeWindow], expected [object ChromeWindow]
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_library_middleclick.js | window made active - Got [object ChromeWindow], expected [object ChromeWindow]
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_library_middleclick.js | window made active - Got [object ChromeWindow], expected [object ChromeWindow]
TEST-UNEXPECTED-FAIL | automation.py | application timed out after 330 seconds with no output

This error message doesn't make any sense to me.  The test failure is off of http://hg.mozilla.org/mozilla-central/rev/b4d603fb501d, which is miles away from places, so I suspect this might be a new rando-orange candidate.

Comment 1

[Marco Bonardo [:mak] (Away July 4-13)]

hm, linux, makes me think to various random we have with the focus manager :(

Comment 2

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269442835.1269444103.28593.gz
Linux mozilla-central opt test mochitest-other on 2010/03/24 08:00:35
s: moz2-linux-slave15

Comment 3

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269445041.1269446570.4781.gz
Linux mozilla-central opt test mochitest-other on 2010/03/24 08:37:21
s: moz2-linux-slave05

Comment 4

[Marco Bonardo [:mak] (Away July 4-13)]

this  is due to a change that has been pushed in february, the problem is that we should waitForFocus twice, once before clicking the link, and once before moving to the next test. The change involved changing focuus between library and browser window when clicking on library's links.

i probably have a fix locally in another patch.

Comment 5

[Legacy TBPL/Treeherder Robot]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1271011275.1271011889.31271.gz
Linux mozilla-central opt test mochitest-other, Started 11:41, finished 11:52

Comment 6

[Marco Bonardo [:mak] (Away July 4-13)]

Attachment: patch v1.0

so the problem is that when we give focus to Library we should wait for it to have focus, then fire the middle click event, then wait for browser to get focus, and so on. We run too much.

Comment 7

[Marco Bonardo [:mak] (Away July 4-13)]

i also enlarged the timeout by 2, looks like since it has to wait focus, it's taking more time.  I just hope Linux won't be picky, that change from february should have gone to its own test, not change this one since it was so much focus related :(
http://hg.mozilla.org/mozilla-central/rev/8a4ad4811877