554199 - Needs to keep external modules in sync with Mozmill (HTTPd.js, EventUtils.js)

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We have two external modules (HTTPd.js and EventUtils.js) which we should keep in sync with the current development on mozilla-central.

I would propose the following:

1. Create a script in the repository which automatically fetches the most recent version of those modules from hg (see the url)

2. Apply necessary diffs (EventUtils.js)

3. Update the packaging script to call that script before building the extension.

That way we will be able to stay in sync as best as possible without having to watch the changes on m-c.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is my proposal for now to solve the situation and keep in sync as best as possible by manually calling the sync script, which downloads the external modules from hg.mozilla.org and applies the local patch on top of both. That way it's easier for us to have both files as current as possible.

Clint, please review the patch on my external_modules branch:
http://github.com/whimboo/mozmill/commit/64ac31a8bf51ea66b8087a88a22fbef5e06d47bb

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Follow-up to fix the broken file name in httpd.patch:
http://github.com/whimboo/mozmill/commit/2ee009a8e792cb19adfec2962b8f8f30bf19853b

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

r+ by Clint via IRC. The code has been merged.

Comment 4

[Heather Arthur [:harth]]

verified that 'python sync_dependencies.py' downloads and applies patches to httpd.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #4)
> verified that 'python sync_dependencies.py' downloads and applies patches to
> httpd.

Please keep in mind that we don't patch httpd correctly at the moment. For more info see bug 583888. We still have to figure out a good way how to do that - if we have to do that.