554253 - Convert nsCOMPtr<nsPresContext> to nsRefPtr<nsPresContext>

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Craig Topper]

nsPresContext is not an interface and should not be using nsCOMPtr. This would cause build failures if nsPresContext gained any more interfaces or lost the one it has.

Comment 1

[Craig Topper]

Attachment: Patch to fix all the places I could find

I temporarily made nsPresContext ambiguously inherit nsISupports and fixed all the build errors to find these. So hopefully that means I got them all.

This is the only questionable part I encountered. Hopefully I did this right.

-  NS_IMPL_CYCLE_COLLECTION_TRAVERSE_NSCOMPTR(mPresContext)
+  NS_IMPL_CYCLE_COLLECTION_TRAVERSE_NATIVE_MEMBER(mPresContext.get(), nsPresContext)

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 434184 [details] [diff] [review]
Patch to fix all the places I could find

thanks!!!

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/c16ec7f0a10c

Comment 4

[Peter Van der Beken [:peterv]]

(In reply to comment #1)
> -  NS_IMPL_CYCLE_COLLECTION_TRAVERSE_NSCOMPTR(mPresContext)
> +  NS_IMPL_CYCLE_COLLECTION_TRAVERSE_NATIVE_MEMBER(mPresContext.get(),
> nsPresContext)

This is very wrong, did you even need to change this at all?

Comment 5

[Craig Topper]

I had temporarily made nsISupports and ambiguous base of nsPresContext so I could make sure I caught all places that were using nsCOMPtr. This piece of code failed because inside the macro NoteXPCOMChild is called which takes an nsISupports. Should we change it back or is there a right way to make it support nsRefPtr?