554552 - Refactor classifications and components templates to use edit-common.html.tmpl and add the 'rows' hook

Status: RESOLVED FIXED

(Bugzilla :: Extensions, enhancement)

Description

[Tiago Mello [:timello]]

Attachment: Factor out common html to edit-common.html.tmpl and add the new hook: rows

Today, neither classification nor component templates use edit-common.html.tmpl to avoid code duplication. Also it would be nice to add the hook: 'rows' allowing new fields to be addded.

Comment 1

[Max Kanat-Alexander]

Comment on attachment 434445 [details] [diff] [review]
Factor out common html to edit-common.html.tmpl and add the new hook: rows

>=== added file 'template/en/default/admin/classifications/edit-common.html.tmpl'
> [snip]
>+  <td><input id="sortkey" size="20" maxlength="20" name="sortkey" value="
>+  [%- classification.sortkey FILTER html %]"></td>

  Nit: Line needs a two-space indent there.

>=== added file 'template/en/default/admin/components/edit-common.html.tmpl'
>+  <td><input size="64" maxlength="64" name="component" value="
>+  [%- comp.name FILTER html %]"></td>

  And there, too.

  Otherwise this looks great! The spacing nits can be fixed on checkin.

  Thanks, timello! :-)

Comment 2

[Tiago Mello [:timello]]

Attachment: Fixing the indentation.

I know it could be fixed in the checkin. But I think it is better indent different:

<td><input id="sortkey" size="20" maxlength="20" name="sortkey" 
           value="[%- classification.sortkey FILTER html %]"></td>

------------

<td><input size="64" maxlength="64" name="component"
           value="[%- comp.name FILTER html %]"></td>

Comment 3

[Max Kanat-Alexander]

Comment on attachment 434993 [details] [diff] [review]
Fixing the indentation.

Agreed, for sure.

Comment 4

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/admin/classifications/add.html.tmpl
added template/en/default/admin/classifications/edit-common.html.tmpl
modified template/en/default/admin/classifications/edit.html.tmpl
modified template/en/default/admin/components/create.html.tmpl
added template/en/default/admin/components/edit-common.html.tmpl
modified template/en/default/admin/components/edit.html.tmpl
Committed revision 7097.