table frames should honor the ascent information (vertical-align:baseline for nested tables)

RESOLVED WORKSFORME

Status

()

Core
Layout: Tables
P3
normal
RESOLVED WORKSFORME
17 years ago
3 years ago

People

(Reporter: Hixie (not reading bugmail), Unassigned)

Tracking

(Depends on: 1 bug, {css1, testcase})

Trunk
Future
css1, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [CSS1-5.4.4])

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

17 years ago
In bug 10207, rbs wrote:
> The remainig case is that of <td> <table> ... </table> </td>. This other 
> special case (but frequent case) won't work because the table code is not yet 
> honoring the ascent. Hence the table code still needs some further tuning so 
> that it returns its ascent (i.e., the ascent of its first row).
> 
> For things to work right, all frames should honor the ascent information.
> Currently, <table> is the remaining HTML frame that is not honoring that 
> information, and 
>    <td valign="baseline"> <table>...</table> </td>
> doesn't mean anything.
> 
> So the table code should return the ascent of its first row.
(Reporter)

Comment 1

17 years ago
We need some test cases for checking vertical-align of nested tables. Things to
check would be three-deep nested tables, colspan and rowspan, interaction with
CSS anonymous tables (e.g. nested display:table-cell elements), etc.
Assignee: clayton → buster
Keywords: correctness, css2, qawanted
QA Contact: petersen → chrisd
Summary: table frames should honor the ascent information → table frames should honor the ascent information (vertical-align:baseline for nested tables)
Whiteboard: need test cases
Target Milestone: --- → Future

Comment 2

17 years ago
With the current setup, the way to go about fixing this bug will involve
caching the table-row's ascent, and the table's ascent and provide means 
to access/manipulate the information. I suggest we keep this bug on hold
as we could get the information differently from nsArea (bug 51684).

Updated

17 years ago
URL: 51684

Updated

17 years ago
URL: 51684
Depends on: 51684

Comment 3

17 years ago
Don't know exactly what this bug is, but I am attaching a file with three-deep 
nested tables, all with vertical-align: baseline values given to TD. Works in 
10/12 build on Win 98

Comment 4

17 years ago
Created attachment 16940 [details]
testcase with nested tables

Comment 5

17 years ago
Created attachment 16981 [details]
modified testcase to expose the problem

Comment 6

17 years ago
The modified testcase was obtained by substituting:

<td style="font-size: 30pt">Comparison cell</td>

to:

<td><table border="0"><tr><td style="font-size: 30pt">Comparison 
cell</td></tr></table></td>
(Reporter)

Comment 7

17 years ago
Upon managerial request, adding the "testcase" keyword to 84 open layout bugs that
do not have the "testcase" keyword and yet have an attachement with the word
"test" in the description field. Apologies for any mistakes.
Keywords: testcase
(Reporter)

Comment 8

17 years ago
Netscape's standard compliance QA team reorganised itself once again, so taking 
remaining non-tables style bugs. Sorry about the spam. I tried to get this done 
directly at the database level, but apparently that is "not easy because of the 
shadow db", "plus it screws up the audit trail", so no can do...
QA Contact: chrisd → ian
(Reporter)

Updated

17 years ago
QA Contact: ian → amar

Comment 9

17 years ago
Adopting bug 64763 "Switch from nsRect mRect to nsArea in the frame model" would 
greatly help this bug.
Depends on: 64763
Build reassigning Buster's bugs to Marc.
Assignee: buster → attinasi
Keywords: css2 → css1
Whiteboard: need test cases → [CSS1-5.4.4]

Comment 11

15 years ago
*** Bug 146146 has been marked as a duplicate of this bug. ***

Comment 12

15 years ago
Created attachment 84747 [details]
Testcase from bug 146146 which is a dupe of this one
*** Bug 181082 has been marked as a duplicate of this bug. ***
(Reporter)

Comment 14

15 years ago
->Tables
Assignee: attinasi → table
Component: Layout → Layout: Tables
*** Bug 183584 has been marked as a duplicate of this bug. ***

Comment 16

15 years ago
this bug and bug 54979 have similar dupes. depending on, blocking?
*** Bug 160325 has been marked as a duplicate of this bug. ***
*** Bug 206430 has been marked as a duplicate of this bug. ***
*** Bug 224415 has been marked as a duplicate of this bug. ***
Blocks: 224415
*** Bug 146146 has been marked as a duplicate of this bug. ***
*** Bug 224415 has been marked as a duplicate of this bug. ***
No longer blocks: 224415
Blocks: 146146

Comment 22

8 years ago
Created attachment 374016 [details]
revised testcase

both attachment 16940 [details]: testcase with nested tables
and attachment 16981 [details]: modified testcase to expose the problem

show on top td {vertical-align: baseline}

this arises from the following markup:

<style="text/css">
td { vertical-align: baseline }
</style

which does not make this a style block, so the tested property does not apply.

This is WFM
Attachment #16940 - Attachment is obsolete: true
Attachment #16981 - Attachment is obsolete: true

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite?
Resolution: --- → WORKSFORME
I suspect I fixed this around when I was implementing inline-block and inline-table.
In particular, I was thinking of bug 367332, although it might have been fixed earlier.

Comment 25

8 years ago
certainly earlier, man all the years I was fooled by the colored testcase,

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060821 SeaMonkey/1.1a
Keywords: qawanted
You need to log in before you can comment on or make changes to this bug.