554572 - Taras' graphs don't work

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

This is a regression from bug 542002 (at least so bisect claims).

STEPS TO REPRODUCE: Load http://people.mozilla.org/~tglek/startup/systemtap_graphs/visualize.html#original.data.html

ACTUAL RESULTS: Red square and JS error.

EXPECTED RESULTS: Pretty graph with some green in it.

ADDITIONAL INFORMATION:
Error: au is not defined
Source File: http://people.mozilla.org/~tglek/startup/systemtap_graphs/support/raphael.js
Line: 7

|au| is a closure var.

I'll attach some files to make it possible to reproduce this directly in bugzilla, including a prettified version or raphael.js that gives a more useful line number and all.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: First js file

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Second js file

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: HTML data file

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase HTML file; load this

Comment 5

[Brendan Eich [:brendan]]

Could use some lithium help reducing this, my by-hand attempt did not work.

/be

Comment 6

[Brendan Eich [:brendan]]

This is due to the problem reported at bug 545759, which is bigger than stated there. I will disable partial flat closures here, and work on a fix to re-enable them in 545759.

/be

Comment 7

[Brendan Eich [:brendan]]

Attachment: require flat closures to flatten all their upvars

This should go into tm and m-c ASAP.

/be

Comment 8

[Brendan Eich [:brendan]]

http://hg.mozilla.org/tracemonkey/rev/91f2500e48e5
http://hg.mozilla.org/mozilla-central/rev/77d5a7f48a4e

/be

Comment 9

[Jesse Ruderman]

Brendan, can you write a testcase now that you know the root cause, or due you still want me to try to reduce the graph code?

Comment 10

[Brendan Eich [:brendan]]

Jesse: I didn't reduce, I just diagnosed -- if you can get the Raphael code that broke reduced a ways, I can help take it further. Thanks,

/be

Comment 11

[Brendan Eich [:brendan]]

Sayrer this is fixed in m-c and tm per comment 8 -- doesn't need betaN+, right?

/be

Comment 12

[:Gavin Sharp [email: [e-mail]]]

In the general case, blocking flags on FIXED bugs are valid - if they get reopened, they likely still need to block.