554842 - Erroneous 'Program terminated unsuccessfully' message from cfx on Windows

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Atul Varma [:atul]]

For example, 'cfx test' might emit the following output on Windows:

"""
.........................................................................................................................................................................................................
Malloc bytes allocated (in use by application): 8834592
Malloc bytes mapped (not necessarily committed): 17678336
Malloc bytes committed (r/w) in default zone: 8833744
Malloc bytes allocated (in use) in default zone: 16629760
Tracked memory objects in testing sandbox: 2

201 of 201 tests passed.
OK
Total time: 6.139673 seconds
Program terminated unsuccessfully.
"""

Everything appears to go ok, yet cfx still seems to think that the program died.

Note that this problem may occur on multiple platforms; it occurred on OS X, for instance, but was fixed in http://hg.mozilla.org/labs/jetpack-sdk/rev/40d3d4dff99f.

Comment 1

[Atul Varma [:atul]]

Attachment: patch

Comment 2

[Atul Varma [:atul]]

Attachment: patch 2, updated against latest trunk

Comment 3

[Atul Varma [:atul]]

Attachment: patch 3, added support for POSIX platforms.

Comment 4

[Atul Varma [:atul]]

The doctest I added in the patch actually failed against my OS X machine, so I updated it to support that. It should work on Linux too, but I haven't actually tested it on that.

Comment 5

[Atul Varma [:atul]]

Attachment: Documented tests, added another one

Comment 6

[Atul Varma [:atul]]

Attachment: patch 5, now using killableprocess.runCommand() instead of killableprocess.Popen().

Comment 7

[Atul Varma [:atul]]

Attachment: patch 6, did away with killableprocess, now just delegating everything to mozrunner

Comment 8

[Atul Varma [:atul]]

I tested this out on Windows 7, Linux (Ubuntu), and OS X and it works fine.

Pushed: http://hg.mozilla.org/labs/jetpack-sdk/rev/ae35f94c48ca

Comment 10

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".