554949 - about:config editor not updating correctly

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

When trying to edit a number (extensions.autoupdate.interval), I noticed that using the keyboard did not seem to change the value. Changing 86400 to 60 using the keyboard, then clicking another row showed "86400" in the displayed value. Clicking back in the row showed "86400" in the editor.

So I use the up/down buttons to edit. This did change the number. Clicking out of the row, then clicking back did show a different number in the editor. However, when clicking out of the row, the displayed value did not change.

The displayed value only changed if I caused the list to refresh using the search filter.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch replace "oncommand" on the textbox from the integer binding to an "oninput"

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 434891 [details] [diff] [review]
Patch

This fixes one problem: When editing the preference using the keyboard, the value is really changed.

But there is still one other problem: after clicking on a different row, the preference value is not displayed correctly.

And there is a new problem with this patch: Changing the preference using the up/down buttons no longer works.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #2)
> (From update of attachment 434891 [details] [diff] [review])
> But there is still one other problem: after clicking on a different row, the
> preference value is not displayed correctly.

Ah, I've not seen this behavior because it seems to works when you don't use the filter.
> 
> And there is a new problem with this patch: Changing the preference using the
> up/down buttons no longer works.

oups!

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch fixe the problem. I've add a comment because there is an other hidden bug which has the same architectural root cause.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 435175 [details] [diff] [review]
Patch

Mark, I'm asking review for this one because this is doing the job for most cases.

It still stay a case ,when there is a preference updated in the background somewhere in the platform, where the update is not working correctly but that's an edge case. If that's ok I'll file a followup for that.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

works well

pushed:
http://hg.mozilla.org/mobile-browser/rev/05b1ce7007c5

Comment 7

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US;
rv:1.9.2.5pre) Gecko/20100414 Namoroka/3.6.5pre Fennec/1.1a2pre