Closed Bug 555002 Opened 15 years ago Closed 15 years ago

OP_findpropglobal[strict] is not rejected by Verifier

Categories

(Tamarin Graveyard :: Virtual Machine, defect, P1)

Product:
Tamarin Graveyard
Component:
Virtual Machine
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
flash10.1

People

(Reporter: edwsmith, Assigned: edwsmith)

References

Details

Attachments

(2 files, 1 obsolete file)

Marks internal opcodes with opcodeLength = -1
1.63 KB, patch
lhansen
: review+
Details | Diff | Splinter Review
test all of the invalid opcodes
5.03 KB, patch
edwsmith
: review+
Details | Diff | Splinter Review
These are VM internal opcodes, so opcodeLength should be -1. Apparently true for OP_lix8/16 too.
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Target Milestone: --- → flash10.1
Assignee: nobody → edwsmith
Status: NEW → ASSIGNED
Attachment #434931 - Flags: review?(lhansen)
Attachment #434931 - Flags: review?(lhansen) → review+
pushed to TR-Argo and TR http://hg.mozilla.org/tamarin-redux/rev/5f716dbd8596
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
needs an abcasm test case that attempts to use the invalid opcodes.
Flags: in-testsuite?
Abcasm support is needed for the new opcodes before regression media can be created: see Bug 559146
Depends on: 559146
Correction - abcasm testcase depends on Bug 490681 in order to insert invalid opcode inline
Depends on: 490681
No longer depends on: 559146
Attached patch abcasm tests for invalid opcodes (obsolete) — — Splinter Review
Attachment #439043 - Flags: review?(edwsmith)
Comment on attachment 439043 [details] [diff] [review] abcasm tests for invalid opcodes Looks good. minor reformatting nit: "todo" and "fixme" comment protocol is: // TODO bug xxxx: rationale Also, while we are at it, we need tests for every invalid opcode. There are 256 possible bytecode values, and many are invalid. Any entry with -1 in the first column is an invalid bytecode. See the bytecode table here: http://hg.mozilla.org/tamarin-redux/file/793fe614d1b5/core/ActionBlockConstants.cpp#l145 0x00, 0x0A, 0x0B, 0x22, ... and so on.
Attachment #439043 - Flags: review?(edwsmith) → review+
Attachment #439043 - Attachment is obsolete: true
Attachment #439632 - Flags: review?(edwsmith)
Comment on attachment 439632 [details] [diff] [review] test all of the invalid opcodes nice test
Attachment #439632 - Flags: review?(edwsmith) → review+
Testcase pushed to redux/argo: http://asteam/hg/tamarin-redux-argo/rev/4e82a6f9e77d
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: