Closed Bug 555290 Opened 14 years ago Closed 14 years ago

add support for Cocoa NPAPI NPCocoaEventWindowFocusChanged events

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(1 file, 4 obsolete files)

fix v1.4 w/tests
33.97 KB, patch
Details | Diff | Splinter Review 
We need to add support for Cocoa NPAPI NPCocoaEventWindowFocusChanged events.
Attached patch fix v1.0 (obsolete) — — Splinter Review 
This isn't all that pretty but it works. Needs tests.
Attachment #439478 - Flags: feedback?(Olli.Pettay)
Comment on attachment 439478 [details] [diff] [review]
fix v1.0

Could you not rename the event type, but just
add new one. Perhaps 
NS_NON_RETARGETED_PLUGIN_EVENT
It is a bit long, but describes the event reasonable well, I think.
Attachment #439478 - Flags: feedback?(Olli.Pettay)
Attached patch fix v1.1 w/tests (obsolete) — — Splinter Review 

        Attachment #440003 -
        Flags: review?(Olli.Pettay)

    
    

    
  
Comment on attachment 440003 [details] [diff] [review]
fix v1.1 w/tests

Forgot to include a fix in v1.1.

        Attachment #440003 -
        Attachment is obsolete: true

        Attachment #440003 -
        Flags: review?(Olli.Pettay) → review?

    
  

        Attachment #439478 -
        Flags: review?(Olli.Pettay)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix v1.2 w/tests (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #439478 -
        Attachment is obsolete: true

        Attachment #440127 -
        Flags: review?(Olli.Pettay)

        Attachment #439478 -
        Flags: review?(Olli.Pettay)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix v1.3 w/tests (obsolete)
        — 
          — Splinter Review
      

    


  
Forgot to document new methods in the test plugin.

        Attachment #440127 -
        Attachment is obsolete: true

        Attachment #440132 -
        Flags: review?(Olli.Pettay)

        Attachment #440127 -
        Flags: review?(Olli.Pettay)

    
  

        Attachment #440132 -
        Flags: review?(roc)

    
    

    
  
All of the event code runs in the parent process, events just get sent to the plugin process at the end.

    
  

        Attachment #440003 -
        Flags: review?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix v1.4 w/tests
        — 
          — Splinter Review
      

    


  
Updated to current trunk.

        Attachment #440132 -
        Attachment is obsolete: true

        Attachment #440132 -
        Flags: review?(Olli.Pettay)

    
    

    
  
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/d50740efad39
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Depends on: 735805

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: