Closed
Bug 555329
Opened 15 years ago
Closed 15 years ago
"New Tab opened" notification not shown opening first tab added to 2nd row in tab panel
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: d_jan, Assigned: vingtetun)
Details
Attachments
(1 file, 1 obsolete file)
1.17 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2) Gecko/20100115 Firefox/3.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: 1.9.2.3pre)
I opened as many tabs that the first collumn is full in the tab-panel. Opening an additional page (which is the first page in a second tab-panel row) via context menu the notification "new Tab opened" is not shown. For additionaly opened tabs it works fine again.
Reproducible: Always
Steps to Reproduce:
1.Open as many tabs as needed to fill the collumn of the tab panel
2.Open an additional tab via context menu. This tab will be the first in a second collumn in the tab bar.
The notification "New Tab opened" does not appear.
3. Open an additional tab via context menu: a notification will show up again.
Actual Results:
---
Expected Results:
A notification "New Tab opened" should always been shown when a new Tab is opened via context menu.
Assignee | ||
Comment 1•15 years ago
|
||
We're failing here:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser-ui.js#685
isTabsVisible returns 0.47 for the first tab of the second row.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•15 years ago
|
tracking-fennec: --- → ?
Assignee | ||
Comment 2•15 years ago
|
||
TabOpen is the only caller of the function and it makes sense to return true only if the tabs sidebar is fully visible.
Assignee: nobody → 21
Attachment #438876 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 3•15 years ago
|
||
Do the proposed change from IRC
Attachment #438876 -
Attachment is obsolete: true
Attachment #438997 -
Flags: review?(mark.finkle)
Attachment #438876 -
Flags: review?(mark.finkle)
Comment 4•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 5•15 years ago
|
||
Comment on attachment 438997 [details] [diff] [review]
Patch v0.2
forgot to r+
Attachment #438997 -
Flags: review?(mark.finkle) → review+
Comment 6•14 years ago
|
||
Retested with:
Mozilla/5.0(Windows NT 5.1; rv:10.0a1) Gecko/20111018 Firefox/10.a1 Fennec/10.a1
Bug no longer reproducible. "New tab opened" notification is displayed also for first tab from 2nd row.
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
tracking-fennec: ? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•