555332 - Website changes for Lorentz

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Benjamin Smedberg]

This bug is a place I can attach the patches to www.mozilla.com that I want feedback on before I actually commit them, because I'm not sure what the commit or review policies are for that site.

Comment 1

[Benjamin Smedberg]

Attachment: Product details, rev. 1

This adds 3.6.3plugin1 as the beta version in product-details and changes the locales so it is actually available.

Comment 2

[Benjamin Smedberg]

Attachment: website changes

This is the website changes apart from product-details. I think it will need further revision, but I'm not sure whether I should check this in to trunk and then get revision, or wait (or use a svn branch, but I've never used one of those and it intimidates me).

I have this all staged locally at http://mozilla-com-stage.smedbergs.us/

Comment 3

[Ryan Doherty (:rdoherty)]

Comment on attachment 435298 [details] [diff] [review]
website changes

Pages look fine to me. 

I'm hesistant on these htaccess changes:

+RewriteCond %{REQUEST_FILENAME} !-f
+RewriteCond %{REQUEST_FILENAME} !-d

Is this normal for mozilla.com? Seems like it would hit our servers hard if every 404 first had to match a regex. 

Also not so sure on:
+php_value short_open_tag TRUE

I'm wary of making a change like that that will affect the entire site. Could cause some weird side effects.

Comment 4

[Reed Loden [:reed]]

Comment on attachment 435298 [details] [diff] [review]
website changes

I'm running out the door, so I don't have time for a full review, but here are my initial comments.

>Index: en-US/firefox/lorentz/plugin-crash-pleasesend.png
>===================================================================
>Cannot display: file marked as a binary type.
>svn:mime-type = application/octet-stream

Images should go under img/.

>+	<ul>
>+	  <li>Adobe Flash
>+	  <li>Microsoft Silverlight
>+          <li>Apple Quicktime
>+        </ul>

Fix spacing.

>+      <p>If one of these plugins crashes or hangs, Firefox will continue running and you can reload the page to try again.

Comma after running.

Also, I see a number of validation errors.

>+php_value short_open_tag TRUE

Indeed, no.

Same comments on redirects....

Comment 5

[Benjamin Smedberg]

FWIW, short_open_tag is already required for mozilla.com, the basic includes require it. I suspect that your PHP config has it set, and I only added it as a local hack for my staging site.

I copied the redirect config from blocks directly above it, the firstrun/eu blocks.

Comment 6

[Alex Buchanan [:abuchanan]]

Comment on attachment 435297 [details] [diff] [review]
Product details, rev. 1

Changes apply and look fine to me, assuming going from 3.7.x -> 3.6.x for latest devel version is OK with everyone.

Comment 7

[Alex Buchanan [:abuchanan]]

Attachment: New page mockup

From what I understand, this page now has a different design planned.  I've attached that mockup and marked the website changes patch obsolete.  Hope that's right.

Ben, do you want to work on this new page?  Or shall I take a stab at it?  What's the timeline for this page?

Comment 8

[Chris Howse [:chowse]]

Attachment: Beta page redesign

New design applied to the Beta page. Nearly complete, but with a few shortcomings:

* The version listed within the Download button (beneath 'Firefox Beta') is appearing as "null" rather than "3.6.3plugin1". I couldn't trace down where this number is being populated. Any help?

* I've placed all the CSS in a separate file, whatsnew-page-lorentz.css, since including the separate CSS that included the visual elements I needed produced too many side effects. Not sure if this is bad practice, or if there's a better alternative.

* The Download Button code was taken from bsmedberg's all-beta page. Non-beta download buttons seems to use different code, so I don't know if there's a better approach.

Comment 9

[Benjamin Smedberg]

the version number comes from product-details, I'll handle that separately

Comment 10

[Alex Buchanan [:abuchanan]]

Comment on attachment 437669 [details] [diff] [review]
Beta page redesign

thanks chowse!

committed in r65422

Comment 11

[Alex Buchanan [:abuchanan]]

(In reply to comment #8)
 
> * I've placed all the CSS in a separate file, whatsnew-page-lorentz.css, since
> including the separate CSS that included the visual elements I needed produced
> too many side effects. Not sure if this is bad practice, or if there's a better
> alternative.

no biggie.  no sense it fighting it.

> * The Download Button code was taken from bsmedberg's all-beta page. Non-beta
> download buttons seems to use different code, so I don't know if there's a
> better approach.

Seems fine to me.  We can double check that everything works in staging.

Comment 12

[Alex Buchanan [:abuchanan]]

Last paragraph, is the "Lorentz beta build" link correct?  It links to all-beta

Comment 13

[Reed Loden [:reed]]

Comment on attachment 435297 [details] [diff] [review]
Product details, rev. 1

>     define('LATEST_FIREFOX_VERSION', '3.6.2');
>-    define('LATEST_FIREFOX_DEVEL_VERSION', '3.7a1pre');
>+    define('LATEST_FIREFOX_DEVEL_VERSION', '3.6.3plugin1');
>     define('LATEST_FIREFOX_OLDER_VERSION', '3.5.8');

This is bitrotten now.

>@@ -42,202 +42,262 @@
>          */
>         var $primary_builds = array(
>                 'af'    => array( LATEST_FIREFOX_OLDER_VERSION => array('Windows' => array('filesize' => 7.6), 'OS X' => array('filesize' => 17.4), 'Linux' => array('filesize' => 9.2) ),
>-                                  LATEST_FIREFOX_VERSION       => array('Windows' => array('filesize' => 7.8), 'OS X' => array('filesize' => 19), 'Linux' => array('filesize' => 9.6) )),
>+                                  LATEST_FIREFOX_VERSION       => array('Windows' => array('filesize' => 7.8), 'OS X' => array('filesize' => 19), 'Linux' => array('filesize' => 9.6) ),
>+                                  LATEST_FIREFOX_DEVEL_VERSION       => array('Windows' => array('filesize' => 7.8), 'OS X' => array('filesize' => 19), 'Linux' => array('filesize' => 9.6) )),

Due to some weirdness in how product-details works, the order needs to be LATEST_FIREFOX_OLDER_VERSION, LATEST_FIREFOX_DEVEL_VERSION, LATEST_FIREFOX_VERSION.

You didn't update the $beta_builds table or history/firefoxHistory.class.php.

Also need to run php -f export_json.php, too.

Comment 14

[Benjamin Smedberg]

Attachment: Product details, unbitrotted

I don't quite understand how product-details work, so I'm just going to attach the unbitrotted patch and ask Reed or Alex to fix the details which I don't understand, if that's all right.

Comment 15

[Reed Loden [:reed]]

Comment on attachment 437669 [details] [diff] [review]
Beta page redesign

>+		var gDownloadItemOtherPlatform = "<a href=\"/en-US/firefox/3.6.3plugin1/releasenotes/#contributedbuilds\">Free Download<\/a>"

Don't hardcore a link like this. Use the product-details define and use $lang.

>+		document.writeln("<a href=\"\/en-US\/firefox\/3.6.3plugin1\/releasenotes\/\">Release Notes<\/a>");

Same.

>+		document.writeln("- <a href=\"\/en-US\/firefox\/all-beta.html\">Other Systems and Languages<\/a>");

$lang

>+			<h3>Download Now - Free <span>(English (US) | <a href="http://www.mozilla.com/en-US/firefox/all.html">Other Systems and Languages</a>)</span></h3>

Relative link here with $lang.

>+				<li><a href="http://download.mozilla.org/?product=firefox-3.6.3plugin1&amp;os=win&amp;lang=en-US">Windows (8<abbr title="MegaBytes">MB</abbr>)</a></li>
>+				<li><a href="http://download.mozilla.org/?product=firefox-3.6.3plugin1&amp;os=linux&amp;lang=en-US">Linux (9.8<abbr title="MegaBytes">MB</abbr>)</a></li>
>+				<li><a href="http://download.mozilla.org/?product=firefox-3.6.3plugin1&amp;os=osx&amp;lang=en-US">Mac OS X (19<abbr title="MegaBytes">MB</abbr>)</a></li>

Don't hardcode. Use product-details. Use $lang.

>+	<p>You can help Mozilla by downloading and using a <a href="/en-US/firefox/all-beta.html">Lorentz beta build</a>. Visit 

$lang


>   <li><a href="http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-firefox-lorentz/firefox-3.6.3plugin1pre.en-US.win32.installer.exe">Windows Installer</a>
>   <li><a href="http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-firefox-lorentz/firefox-3.6.3plugin1pre.en-US.linux-i686.tar.bz2">Linux Tarball</a>

Don't hardcode.

Comment 16

[Reed Loden [:reed]]

Comment on attachment 437842 [details] [diff] [review]
Product details, unbitrotted

Giving this r- just so somebody won't accidentally commit it.

Comment 17

[Mike Beltzner [:beltzner, not reading bugmail]]

Reed - you r-'d a patch that Alex approved and that I believe got committed. Are you available to help with the product-details changes and associated html changes?

If not, Alex, can we get some of your time today?

Comment 18

[Alex Buchanan [:abuchanan]]

I can help clean up.  Thanks reed for the reviews.

Comment 19

[Chris Howse [:chowse]]

Attachment: Beta page update

- Added $lang refs in all the links.
- Added a missing link on 'release notes' at the bottom of the page.

I'm not sure how to use product-details for the download links. Alex, I'm hope you can fix this last detail.

Comment 20

[Alex Buchanan [:abuchanan]]

Attachment: P-d patch

Moved $primary_builds entries around per comment #13

A couple questions:

1) Are there beta locales for this build?  Not sure what needs updating in $beta_builds

2) How do I know what date to put in history/firefoxHistory ?

Comment 21

[Alex Buchanan [:abuchanan]]

Attachment: page HTML patch

Fixes hardcoding of version numbers and locale codes.

Notes:

1) We'll need to remove the .htaccess rule for all-beta.html.  Currently it shows 3.6.3 builds (pass through to all.html)

2)  How can we generate the nightly build links, so they're not hardcoded (comment #15)?

Comment 22

[Alex Buchanan [:abuchanan]]

(In reply to comment #17)
> Reed - you r-'d a patch that Alex approved and that I believe got committed.
> Are you available to help with the product-details changes and associated html
> changes?

BTW, this was never committed.

Comment 23

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #21)
> Created an attachment (id=437892) [details]
> page HTML patch
> 
> Fixes hardcoding of version numbers and locale codes.
> 
> Notes:
> 
> 1) We'll need to remove the .htaccess rule for all-beta.html.  Currently it
> shows 3.6.3 builds (pass through to all.html)

It currently redirects to all.html, yeah; we should remove that and have it point to these lorentz builds, and then eventually to the 3.6.4 beta builds.

> 2)  How can we generate the nightly build links, so they're not hardcoded
> (comment #15)?

I think the nightly build links section has been removed, hasn't it? It should also point to all-beta, really.

Comment 24

[Benjamin Smedberg]

The current nightly-build link goes to 1.9.2 nightly builds. Do we have a landing page to get people on 1.9.2 nightlies?

Comment 25

[Alex Buchanan [:abuchanan]]

(In reply to comment #23)
> It currently redirects to all.html, yeah; we should remove that and have it
> point to these lorentz builds, and then eventually to the 3.6.4 beta builds.

My working copy was out of date, this has already been fixed by someone.

> I think the nightly build links section has been removed, hasn't it? It should
> also point to all-beta, really.

Looking here: http://www-trunk.stage.mozilla.com/en-US/firefox/lorentz/

Bottom right corner, there is a nightly builds section.  You're saying I should remove that block?  Replace it with anything?  

Thanks

Comment 26

[Stephen Donner [:stephend] Not actively reading bugmail]

The page doesn't validate to its HTML5 doctype: http://validator.w3.org/check?uri=http%3A%2F%2Fwww-trunk.stage.mozilla.com%2Fen-US%2Ffirefox%2Florentz%2F&charset=%28detect+automatically%29&doctype=Inline&group=0

Comment 27

[Alex Buchanan [:abuchanan]]

(In reply to comment #26)
> The page doesn't validate to its HTML5 doctype:
> http://validator.w3.org/check?uri=http%3A%2F%2Fwww-trunk.stage.mozilla.com%2Fen-US%2Ffirefox%2Florentz%2F&charset=%28detect+automatically%29&doctype=Inline&group=0

The page on trunk doesn't have the most recent patches applied yet.  It will validate once they are

Comment 28

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #25)
> Bottom right corner, there is a nightly builds section.  You're saying I should
> remove that block?  Replace it with anything?  

Yeah, I think we can remove that block. We *could* point people to nightly.mozilla.org, but I don't think it's a huge advantage. Let's make this page be about Lorentz

Comment 29

[Alex Buchanan [:abuchanan]]

Attachment: html patch, removes nightly block

ok, thanks.  New patch removes nightly block.

What's ETA on this build?  Today?  This week?

Comment 30

[Benjamin Smedberg]

They are being staged now, so today.

Comment 31

[Alex Buchanan [:abuchanan]]

Attachment: p-d patch, adds entry to firefox-history

Added 3.6.3plugin1 to firefox history file, with today's date

Comment 32

[Alex Buchanan [:abuchanan]]

html patch committed in r65485
p-d committed in r65486

Comment 33

[Alex Buchanan [:abuchanan]]

Page looks good on trunk.  Over to QA.

Comment 34

[Alex Buchanan [:abuchanan]]

r65491 tweaks the beta download button CSS slightly, so that the text doesn't overflow the background image (caused by longer version numbers)

Comment 35

[raymond [:retornam] (inactive)]

http://www-trunk.stage.mozilla.com/en-US/firefox/lorentz/ looks good to me. The text button overflow is fixed

Comment 36

[Reed Loden [:reed]]

Comment on attachment 437925 [details] [diff] [review]
html patch, removes nightly block

Note the earliest I can get to this is tomorrow afternoon, and I'll only have a few hours. However, I'll put it on my schedule.

Comment 37

[Reed Loden [:reed]]

Comment on attachment 437926 [details] [diff] [review]
p-d patch, adds entry to firefox-history

still think we probably need to update the beta builds array... need to see what builds are actually being built.

Comment 38

[Kohei Yoshino [:kohei]]

> Firefox "Lorentz" provides uninterrupted browsing for Windows and Linux users

Lorentz is only for Win/Linux? Why these is a Mac build? It's confusing.

Comment 39

[Mike Beltzner [:beltzner, not reading bugmail]]

The new feature only works on Windows and Linux. There are OSX builds because we want to make sure that the code changes do not cause problems for OSX users.

Reed: should we mark this fixed or wait until the beta array stuff is finished?

Comment 40

[Kohei Yoshino [:kohei]]

Firefox logo is old:
http://www.mozilla.com/en-US/firefox/3.6.3plugin1/whatsnew/

Comment 41

[Alex Buchanan [:abuchanan]]

This went live, so we can close this right?

Comment 42

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #41)
> This went live, so we can close this right?

Yep.