Closed Bug 555335 Opened 10 years ago Closed 10 years ago

macosx64 generated package does not indicate architecture

Categories

(Firefox Build System :: General, defect)

x86_64
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a4

People

(Reporter: bear, Assigned: ted)

References

Details

Attachments

(1 file)

The new 10.6 builds introduce the need for the DMG filename to reflect 32bit or 64bit architecture.

firefox-3.7a4pre.en-US.mac.dmg could be either - you don't know until you try to install and it fails.
The bit that sets the platform is right here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/package-name.mk#61

We can change that to mac64 or whatever Josh wants.
Product: Firefox → Core
QA Contact: build.config → build-config
Version: unspecified → Trunk
bear/bhearsum, this is more than cosmetic. We need a filename fix to land before enabling 10.6 builds on mozilla-central, or we'll break nightly updates users by unintentionally creating 32 -> 64 bit partial mars. We'll also need bug 552924 to prevent 64bit users getting "downgraded" to ppc/i386 builds.

Similarly if we've started using nightly-partials-on-slaves on any branches derived from m-c, then they'll need to merge from m-c before we can add 10.6 builders.
Attached patch untested patchSplinter Review
Pretty simple patch, but I don't have a 10.6 machine so I can't really test it. bear: can you give this a spin and ensure that it does what you want?

Josh: does this look ok? We'll wind up with build filenames like "firefox-3.7a4pre.en-US.mac64.dmg".
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #435622 - Flags: review?(joshmoz)
Attachment #435622 - Flags: review?(joshmoz) → review+
(In reply to comment #3)
> Created an attachment (id=435622) [details]
> untested patch
> 
> Pretty simple patch, but I don't have a 10.6 machine so I can't really test it.
> bear: can you give this a spin and ensure that it does what you want?
> 
> Josh: does this look ok? We'll wind up with build filenames like
> "firefox-3.7a4pre.en-US.mac64.dmg".

I'll work this on to the test machine right now and report back
tested the patch on the 10.6 reference image and it worked as described.

the binary is x86_64 and the generated dmg was named firefox-3.7a4pre.en-US.mac64.dmg

+1
What is required now to land this change? Any blocking item that I can help with?
Nope, just needs landed. Didn't get to it today, I should have time tomorrow. If I still don't get to it by then, feel free to have someone else land it.
Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/4d914ba3a52d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Hardware: x86 → x86_64
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.