55546 - Filepicker filter list empty on first run

Status: VERIFIED DUPLICATE of bug 54784

(Core :: XUL, defect, P2)

Description

[Brian Ryner (not reading)]

The first time you run Mozilla, the filter list in the filepicker will show "()"
instead of the file extensions and descriptions.  Works ok on subsequent runs.

I believe the problem is that we are obtaining the string bundle as a
file-global variable in nsFilePicker.js - this is executed during component
registration, which is BEFORE the locale is initialized.

Attaching a proposed patch.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Mike Shaver (:shaver emeritus)]

a=shaver

Comment 3

[Peter "jag" Annema]

r=jag

Comment 4

[Brian Ryner (not reading)]

Nominating for rtm, based on:

1) apparent loss of functionality
2) extremely safe fix
3) fix in hand, reviewed and super-reviewed

Comment 5

[Brian Ryner (not reading)]

trudelle: do you think this is rtm-worthy? Or is "start again" too much of an
easy workaround?

Comment 6

[Peter Trudelle]

Looks like a righteous fix to me.  rtm+   How well-tested is this? Does change
affect any other execution path? Should we get more testing by landing on trunk
first?

Comment 7

[Peter Trudelle]

Note that workaround is easy iff you are motivated to use the program.  If
you're just evaluating it, you may not run it a second time.  First impressions
matter a lot.

Comment 8

[Brian Ryner (not reading)]

I'd say this is extremely safe.  We can do a trunk landing first if you want though.

Comment 9

[Brian Ryner (not reading)]

Oh, and no, no other execution paths are affected.  Just delaying something from
filepicker component registration until a filepicker window is opened.

Comment 10

[Brian Ryner (not reading)]

this was fixed in the more general case by the checkin to fix 54784.  marking dup.


*** This bug has been marked as a duplicate of 54784 ***

Comment 11

[John Morrison]

verified duplicate.