555661 - mozilla::plugins::PluginInstanceChild::InternalGetNPObjectForValue should fail for unknown NPNVariable aValue

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect)

Description

[timeless]

149 PluginInstanceChild::InternalGetNPObjectForValue(NPNVariable aValue,

152     PluginScriptableObjectChild* actor;
153     NPError result = NPERR_NO_ERROR;

155     switch (aValue) {
156         case NPNVWindowNPObject:
168             break;

170         case NPNVPluginElementNPObject:
183             break;

185         default:
186             NS_NOTREACHED("Don't know what to do with this value type!");

215     if (result != NPERR_NO_ERROR) {
217     }

219     NPObject* object = actor->GetObject(false);

Comment 1

[timeless]

Attachment: fail

Comment 2

[Josh Aas]

Comment on attachment 435561 [details] [diff] [review]
fail

Your patch can cause NPN_GetValue to return NPERR_INVALID_PARAM for an unknown param. This does not match in-process plugins or even the behavior of the calling function, which returns NPERR_GENERIC_ERROR for unknown variables. We should be consistent.

I think we should stick with our old behavior of returning NPERR_GENERIC_ERROR for unknown variables, so just change the error type in your patch to NPERR_GENERIC_ERROR.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Hang on. We only call InternalGetNPObjectForValue from PluginInstanceChild::NPN_GetValue after we've check the NPNVariable, I think this bug is INVALID.

Comment 4

[Benjamin Smedberg]

Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.