Closed
Bug 555704
Opened 15 years ago
Closed 15 years ago
useless null check of baseView in nsViewManager::DispatchEvent
Categories
(Core :: Web Painting, defect)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file)
|
671 bytes,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
371 static nsView* GetDisplayRootFor(nsView* aView)
372 {
373 nsView *displayRoot = aView;
374 for (;;) {
375 nsView *displayParent = displayRoot->GetParent();
758 NS_IMETHODIMP nsViewManager::DispatchEvent(nsGUIEvent *aEvent,
975 nsView* baseView = static_cast<nsView*>(aView);
976 nsView* view = baseView;
978 if (NS_IsEventUsingCoordinates(aEvent)) {
981 view = GetDisplayRootFor(baseView);
984 if (nsnull != view) {
1042 if (baseView) {
1043 baseView->GetDimensions(baseViewDimensions);
Attachment #435603 -
Flags: review?(roc) → review+
|
||
Comment 2•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
|
||
Updated•7 years ago
|
Blocks: coverity-analysis
|
||
Updated•7 years ago
|
Component: Layout: View Rendering → Layout: Web Painting
You need to log in
before you can comment on or make changes to this bug.
Description
•