Closed Bug 555704 Opened 10 years ago Closed 10 years ago

useless null check of baseView in nsViewManager::DispatchEvent

Categories

(Core :: Web Painting, defect, minor)

Product:
Core
Component:
Web Painting
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a5

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: coverity)

Attachments

(1 file)

remove it
671 bytes, patch
roc
: review+
Details | Diff | Splinter Review 
371 static nsView* GetDisplayRootFor(nsView* aView)
372 {
373   nsView *displayRoot = aView;
374   for (;;) {
375     nsView *displayParent = displayRoot->GetParent();

758 NS_IMETHODIMP nsViewManager::DispatchEvent(nsGUIEvent *aEvent,

975         nsView* baseView = static_cast<nsView*>(aView);
976         nsView* view = baseView;

978         if (NS_IsEventUsingCoordinates(aEvent)) {

981           view = GetDisplayRootFor(baseView);

984         if (nsnull != view) {

1042           if (baseView) {
1043             baseView->GetDimensions(baseViewDimensions);
Attached patch remove it — — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #435603 - Flags: review?(roc)
http://hg.mozilla.org/mozilla-central/rev/99e9ec4fb2c9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.