Closed Bug 555706 Opened 10 years ago Closed 10 years ago

useless null checks of a and b in _cairo_path_fixed_equal

Categories

(Core :: Graphics, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file)

204 _cairo_path_fixed_equal (const cairo_path_fixed_t *a,

217     if (a->has_curve_to != b->has_curve_to ||

225     if (a != NULL) {

233     if (b != NULL) {
oh, how could i miss:
246     assert (a != NULL && b != NULL);
Attached patch remove them all!Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #435606 - Flags: review?(jmuizelaar)
It's better to submit this kind of stuff upstream directly.
sorry, i'm hoping the maintainer (you) would do that. i have a lot of bugs to file and it takes me too many cycles to find the right upstreams.
I've pushed this upstream.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #435606 - Flags: review?(jmuizelaar)
You need to log in before you can comment on or make changes to this bug.