555710 - Should be able to show locales as beta

Status: RESOLVED FIXED

(www.mozilla.org Graveyard :: Thunderbird, defect, P1)

Description

[Mark Banner (:standard8)]

For the Thunderbird 3.0.4 release, we want to be able to show Slovenian as a beta locale. mozilla.com uses an image on the website with "Beta Locale" embedded into it.

We should find a solution that will work for Slovenian, and for any future locales that want to join us as beta locales.

Comment 1

[Rafael Ebron (:rebron)]

http://dl.dropbox.com/u/184285/download-button-primary.png

Does this work?

Comment 2

[Rafael Ebron (:rebron)]

Where is this image going?

Comment 3

[Mark Banner (:standard8)]

Whoops, just noticed this was in the mozilla.com component not the mozillamessaging.com one.

Comment 4

[Mark Banner (:standard8)]

Attachment: Proposed fix

So I think the image you've referenced, combined with this patch will do the beta locale for the page here:

http://www.mozillamessaging.com/sl/thunderbird/

I think we may need a slightly different image, or css for:

http://www.mozillamessaging.com/sl/

Going forward, I think we need to think about getting extra attributes/classes generated on the elements so that we can just do this automatically without specific css for each locale.

I'll put that against my list of things that will improve the way we do releases.

Comment 5

[Mark Banner (:standard8)]

Attachment: 3.0.5 product details changes (draft)

This patch applies for the trunk/includes/product-details section. I'm going to be doing a formal bug to get it reviewed & approved. However...

Sancus, would you be apply this patch and the "Proposed Fix" to your own copy of momo.com so that we can test out the changes for displaying Slovenian as a beta locale? (because of the changes to product-details, its much easier to do that not on *.mozillamessaging.com).

Comment 6

[Andrei Hajdukewycz [:sancus]]

http://momo.last-chance.net/sl/thunderbird/ shows this stuff applied, I fixed the CSS as the width of the <ul> needs to be wider to accomodate the larger image. Not sure why it's showing the older thunderbird version, though. Should it be showing 3.0.5?

Comment 7

[Mark Banner (:standard8)]

(In reply to comment #6)
> http://momo.last-chance.net/sl/thunderbird/ shows this stuff applied, I fixed
> the CSS as the width of the <ul> needs to be wider to accomodate the larger
> image. Not sure why it's showing the older thunderbird version, though. Should
> it be showing 3.0.5?

Yeah, looks like it should be. http://momo.last-chance.net/en-US/thunderbird/all.html is pointing to 3.0.5, so I think the table is right, maybe somewhere in the php is wrong.

Also, should we be making this page show beta language as well:

http://momo.last-chance.net/sl/

Comment 8

[Andrei Hajdukewycz [:sancus]]

Attachment: 3.0.5 product details changes updated

Changes we worked out on IRC.

Comment 9

[Mark Banner (:standard8)]

Attachment: Product details regenerated

Ok, I've updated my script and this should work the same as what Andrei and I discussed. Andrei can you confirm this still works the same?

Comment 10

[Andrei Hajdukewycz [:sancus]]

Comment on attachment 449951 [details] [diff] [review]
Product details regenerated

Yep this works, tested it.

Comment 11

[Andrei Hajdukewycz [:sancus]]

I'll get the CSS fixed for http://momo.last-chance.net/sl/ as well and then this should be done.

Comment 12

[Andrei Hajdukewycz [:sancus]]

We do need a different image for: http://momo.last-chance.net/sl/

I checked in the function call change to all-older.html in r68615.

Comment 13

[Mark Banner (:standard8)]

(In reply to comment #12)
> We do need a different image for: http://momo.last-chance.net/sl/
> 
> I checked in the function call change to all-older.html in r68615.

I pushed it to production in r68669 as I was pushing something else there anyway and it cuts down what we need to push for 3.0.5.

Comment 14

[Mark Banner (:standard8)]

Have we resolved this yet? We're going to need this in the next day or so hopefully.

Comment 15

[Andrei Hajdukewycz [:sancus]]

No, still need an appropriate 'beta' image for http://momo.last-chance.net/sl/

Comment 16

[Andrei Hajdukewycz [:sancus]]

Attachment: updated css

Comment 17

[Andrei Hajdukewycz [:sancus]]

http://momo.last-chance.net/sl/ works, I had to shift the text down a few pixels so it didn't sit on top of the beta language part. Not sure if we want to change that image, but I think it looks OK as-is.

Comment 18

[Andrei Hajdukewycz [:sancus]]

r68959 is the images
r68960 is the css changes

I separated them since we'll likely re-use the images.

Comment 19

[Andrei Hajdukewycz [:sancus]]

Well, we can now show locales as beta, so this is fixed. This process could probably use some improvement and so I may open another bug once I brainstorm a little; I'll CC the people on this bug if I do so.