555725 - Panning allowed after context menu is instanced

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.3pre) Gecko/20100329 Namoroka/3.6.3pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.3a4pre) Gecko/20100329 Namoroka/3.7a4pre Fennec/1.1a2pre

Steps to Reproduce:
1. Go to www.espn.com
2. Long-tap on a image to open the context menu. Keep your finger down on the screen. 
3. Pan around the page

Actual Results:
The context menu stays on the screen, but you're able to pan around the page

Expected Results:
I'd expect either one of two things to happen:

1. The context menu goes away and I'm able to pan around the page
2. I'm not able to pan around the page until I perform another mousedown and pan action (where the context menu dissapears)

Comment 1

[Madhava Enros [:madhava]]

Nothing should happen (including panning) until you lift your finger.  The context menu should remain, on finger-up, because it doesn't go away until you pick something or tap off of it.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Correct this bug and also bug 556658.
I'm also not able to reproduce bug 556771 but it can be my fault :)

I know the patch is quite dirty. I'm filing a followup for making a better InputHandler.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 438082 [details] [diff] [review]
Patch

Works well

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/536b689be337

Comment 5

[Aakash Desai [:aakashd]]

NICE, verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.4pre) Gecko/20100412 Namoroka/3.6.4pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a4pre) Gecko/20100412 Namoroka/3.7a4pre Fennec/1.1a2pre

Comment 6

[Aakash Desai [:aakashd]]

I think this deserves some sort of updates to one of the BFTs in our context menu subgroup.

Comment 7

[Tony Chung [:tchung]]

https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=11813