555850 - fields.html help should happen when hovering over field labels

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Max Kanat-Alexander]

I was reading the HCI research results again (and I was talking a bit with pyrzak about this also) and I noticed that it's not just the lack of fields.html help for each field that was confusing, but the very fact that clicking on the links would take people to the help was confusing.

  I think that perhaps in addition to the links, we could have a tooltip for the field labels, and change the cursor to the "arrow with question mark" cursor.

  I don't want to use the Help System (which instantly positions overlays containing help) because it can be annoying and block off the form, whereas tooltips are (a) easy and (b) a normal and expected browser mechanism that doesn't cause trouble.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, this patch is a bit large because it does three or four things. If you want me to split it into three separate patches, just let me know. Here are all the things it does:

  1) Refactors the label code for fields into bug/field-label.html.tmpl
  2) Modifies field-label.html.tmpl to display a tooltip for anything that has help in help_html, and adds all custom fields to help_html.
  3) Switches the create.html.tmpl template to using field.html.tmpl for the bug_status field.
  4) Modifies create.html.tmpl to use field-label for all the fields that had a help link before.

  I'll do show_bug in a separate patch, since we haven't even implemented help links for everything on show_bug yet.

Comment 2

[Frédéric Buclin]

Comment on attachment 435758 [details] [diff] [review]
v1

The changes in enter_bug.cgi have nothing to do with the bug. They are not even a code cleanup (they just make it harder to track changes in Bonsai). Why doing these changes?

Comment 3

[Max Kanat-Alexander]

  The enter_bug changes do have to do with the bug. In order for fields.html to work, we have to pass objects to the template, not strings.

Comment 4

[Tiago Mello [:timello]]

Comment on attachment 435758 [details] [diff] [review]
v1

The patch is bit-rotted. It does not apply in trunk. enter_bug.cgi has been changed.

Comment 5

[Max Kanat-Alexander]

Attachment: v2

Ah, thanks for catching that! Here's a fix for the bitrot.

Comment 6

[Tiago Mello [:timello]]

Comment on attachment 445054 [details] [diff] [review]
v2

It is breaking runtest :(.

t/008filter.t.

Comment 7

[Max Kanat-Alexander]

Attachment: v3

Ah, thanks! Fixed.

Comment 8

[Tiago Mello [:timello]]

Comment on attachment 445107 [details] [diff] [review]
v3

>=== modified file 'template/en/default/bug/create/create.html.tmpl'
>+    [% INCLUDE bug/field.html.tmpl
>+      bug = default, field = bug_fields.bug_status,
>+      editable = (bug_status.size > 1), value = default.bug_status
>+      override_legal_values = bug_status  %]

Nit: one space more before the '%]'.

The rest ok! Nice code change! Much better now!

Comment 9

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified enter_bug.cgi
modified skins/standard/global.css
modified template/en/default/filterexceptions.pl
modified template/en/default/bug/field-help.none.tmpl
added template/en/default/bug/field-label.html.tmpl
modified template/en/default/bug/field.html.tmpl
modified template/en/default/bug/create/create.html.tmpl
modified template/en/default/pages/fields.html.tmpl
Committed revision 7162.