556003 - [mozmill] Tests for the master password feature leave modal dialogs open and let Firefox hang

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When running the tests for the master password dialog Firefox will hang because at least one dialog doesn't get closed automatically because of a failure.

We should fix that as soon as possible.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1 (default)

Until we have the better solution for modal dialogs we only can increase the time we are waiting before checking for a new modal dialog. This patch increased the first delay for the modal dialog observer from 200 to 500ms. That should be enough time for the new modal dialog and that the observer doesn't detect the preferences dialog itself as the modal dialog.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1.1 (default)

Lets use the gDelay variable to have the delay/timeout only specified once.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/325158e1eb43
http://hg.mozilla.org/qa/mozmill-tests/rev/ce1d4c2801cf
http://hg.mozilla.org/qa/mozmill-tests/rev/b163f6cd094e

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.