Use :moz-locale-dir pseudoclass instead of chromedir attribute

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
seamonkey2.1a1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 436016 [details] [diff] [review]
Switch from chromedir to :moz-locale-dir

For the record, subscribe.xhtml, aboutSessionRestore.xhtml, certError.xhtml use the same entity and it still lives in brand.dtd. Modern's scrollbox.css (obviously ported from windtripe) looks wrong to me - In rtl mode, I get the right-arrow at the left side of the menus (I expected the left-arrow at the left side). You can try this by adding the "intl.uidirection.en-US" pref and set it to "rtl".
Attachment #436016 - Flags: superreview?(neil)
Attachment #436016 - Flags: review?(kairo)
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED

Comment 1

7 years ago
Comment on attachment 436016 [details] [diff] [review]
Switch from chromedir to :moz-locale-dir

> #tabs > :first-child,
>-#tabs[chromedir=rtl] > :last-child {
>+#tabs:-moz-locale-dir(rtl) > :last-child {
>   -moz-border-radius-topleft: 2px;
>   -moz-border-radius-bottomleft: 2px;
>    border-left: none !important;
> }
> 
> #tabs > :last-child,
>-#tabs[chromedir=rtl] > :first-child {
>+#tabs:-moz-locale-dir(rtl) > :first-child {
>   -moz-border-radius-topright: 2px;
>   -moz-border-radius-bottomright: 2px;
> }
Doesn't this need ltr on the other rules, otherwise in an rtl environment both sets of rules will apply to both first and last tabs?
Attachment #436016 - Flags: superreview?(neil) → superreview+

Comment 2

7 years ago
(In reply to comment #0)
> Modern's scrollbox.css (obviously ported from windtripe) looks wrong to me -
> In rtl mode, I get the right-arrow at the left side of the menus
What does scrollbox.css have to do with menu arrows? It's only used e.g. when you have zillions of bookmarks in a single folder and they don't fit on screen.
(Assignee)

Comment 3

7 years ago
(In reply to comment #2)
> (In reply to comment #0)
> > Modern's scrollbox.css (obviously ported from windtripe) looks wrong to me -
> > In rtl mode, I get the right-arrow at the left side of the menus
> What does scrollbox.css have to do with menu arrows? It's only used e.g. when
> you have zillions of bookmarks in a single folder and they don't fit on screen.

It has nothing to do with menu arrows, I don't know what I was thinking of :-(

Updated

7 years ago
Attachment #436016 - Flags: review?(kairo) → review+
(Assignee)

Comment 4

7 years ago
Fixed with Neil's comment #1 addressed: http://hg.mozilla.org/comm-central/rev/b9be42774b92
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.