556190 - op_filok NSPR test fails on Android

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Alex Pakhotin (:alexp)]

The test is looking for a file, which does not exist on Android.

Comment 1

[Alex Pakhotin (:alexp)]

Attachment: Fix

Use argv[0] as a name of the file, which must exist.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 436121 [details] [diff] [review]
Fix

Wan-Teh, what do you think? This would make it a more generic test.

Alternatively /system/bin/app_process is always present on android

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 436121 [details] [diff] [review]
Fix

moving the review over to ted since wtc hasn't gotten to this in a few months. 

Also, alex, should this be blocking fennec and if so why?

Comment 4

[Alex Pakhotin (:alexp)]

(In reply to comment #3)
> Also, alex, should this be blocking fennec and if so why?

It's the test itself, so it does not block Fennec.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 436121 [details] [diff] [review]
Fix

Seems reasonable.

Comment 6

[(not currently active) Ted Mielczarek]

Checking in pr/tests/op_filok.c;
/cvsroot/mozilla/nsprpub/pr/tests/op_filok.c,v  <--  op_filok.c
new revision: 3.17; previous revision: 3.16
done