556301 - Session Close window appears when tagging a bookmark

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Tony Chung [:tchung]]

Attachment: session close screenshot

The session close window will always appear when trying to add a tag to a new bookmark.   We shouldn't be seeing this.

Screenshot.  Tested on both desktop builds and n900 build.

Repro:
1) Download 1.1a2pre 20100330 build
2) open any unbookmarked webpage (eg. amazon)
3) bookmark the site
4) in the bookmark window, click edit tags 
5) enter in something
6) Click done, and verify the session close window will always appear after saving a bookmark

Expected;
- no session close window here

Actual:
- session close window

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I am having trouble reproducing this bug. This are working ok for me.

Comment 2

[Aakash Desai [:aakashd]]

This works for me as well on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.4pre) Gecko/20100406 Namoroka/3.6.4pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a4pre) Gecko/20100406 Namoroka/3.7a4pre Fennec/1.1a2pre


Tony, can you try this with a new profile?

Comment 3

[Matt Brubeck (:mbrubeck)]

I can reproduce this in my Linux desktop trunk build, with slightly different repro steps:

1. Open at least two tabs.
2. In one of the tabs, bookmark a page OR load a bookmarked page.
3. Press the bookmark star and then press the "Edit" button.
4. Press "Done" in the boomark edit dialog.

This is also causing a timeout failure in chrome/tests/browser_bookmarks_star.js.

Comment 4

[Matt Brubeck (:mbrubeck)]

Here's the stack trace.  The "close" event when the bookmark dialog closes is bubbling up and triggering the browser.xul onclose handler.

browser/content/browser.js :: closing :: line 549
browser/content/browser.xul :: onclose :: line 1
browser/content/bindings.xml :: stopEditing :: line 488
browser/content/browser-ui.js :: BH_save :: line 1164
browser/content/browser.xul :: oncommand :: line 1

Comment 5

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This patch disables bubbling on the placeitem "close" event.

I checked that nothing expects this event to bubble.  BookmarkHelper attaches its handler directly to the placeitem where the event is dispatched, and there are no close handlers on any of the parent elements (#bookmark-form, #bookmark-container, #stack).

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/59949ddbc133

Comment 7

[Tony Chung [:tchung]]

Verified fix on N900: Mozilla/5.0 (X11; U; Linux armv7l; en-US;
rv:1.9.2.4pre) Gecko/20100411 Namoroka/3.6.4pre Fennec/1.1a2pre 
and Desktop: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
rv:1.9.2.4pre) Gecko/20100412 Namoroka/3.6.4pre Fennec/1.1a2pre