556353 - Remove OBJ_IS_NATIVE, HAS_FUNCTION_CLASS

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

Attachment: patch

More cleaning up:

- Rename lockAnd{Get,Set}Slot() as {get,set}SlotMT(), as per Brendan's
  request in bug 555631.

- Remove HAS_FUNCTION_CLASS and replace all its uses with obj->isFunction().

- Remove OBJ_IS_NATIVE and replace all its uses with obj->isNative().

Comment 1

[Brendan Eich [:brendan]]

Comment on attachment 436258 [details] [diff] [review]
patch

Stealing, gal won't mind I'm sure -- very pretty, glad to see BIG_UGLY_MACRO names bite the dust.

VALUE_TO_FUNCTION and GET_FUNCTION_PRIVATE need to go, in this light.

Thanks for doing this!

/be

Comment 2

[Andreas Gal :gal]

Its _always_ ok to steal from me =)

Comment 3

[Nicholas Nethercote [inactive]]

(In reply to comment #1)
> VALUE_TO_FUNCTION and GET_FUNCTION_PRIVATE need to go, in this light.

Yes, and 101 other ones like it.  I'll get there, I just like doing it in chunks -- it gives fewer difficulties when updating, it's easier for reviewers, and easier to work out problems if something goes wrong (just ask Waldo, cough *bug 548702* cough).

> Thanks for doing this!

No problem.  I actually don't mind doing this kind of stuff.

Comment 4

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/tracemonkey/rev/fd93131c3bb9

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/fd93131c3bb9