556373 - Move the adding/removing of groups from process_bug.cgi to Bugzilla::Bug::set_all

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Comment 1

[Max Kanat-Alexander]

Attachment: v1

In the interest of code simplicity, there's a slight change in behavior here for edit-multiple. Now, if you try to add a bunch of bugs to a group, and one of the bugs can't actually be in that group, then you'll get an error instead of it silently ignoring the invalid group. I think this is probably actually better, since adding bugs to groups is a security issue, and people want to know if that doesn't actually happen.

  I moved the Flags stuff because it's theoretically possible for the "component" field to not be set until after set_all, even now. (It was always in the wrong place.)

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 436313 [details] [diff] [review]
v1

Looks good and all works as expected. r=dkl

Comment 3

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified process_bug.cgi
modified Bugzilla/Bug.pm
Committed revision 7178.