556405 - Support building qcms on Android

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Description

[Michael Wu [:mwu]]

Some hacks are necessary to build on Android.

Comment 1

[Michael Wu [:mwu]]

Attachment: Support building qcms on Android

These are the changes Vlad made on the mozilla-droid repo to allow qcms to build. http://hg.mozilla.org/users/vladimir_mozilla.com/mozilla-droid/rev/40b367ada1bd

Comment 2

[Jeff Muizelaar [:jrmuizel]]

What's the purpose of this hunk?

 //XXX: use a better typename
+#ifndef ANDROID
 typedef uint32_t __be32;
 typedef uint16_t __be16;
+#endif

Comment 3

[Michael Wu [:mwu]]

(In reply to comment #2)
> What's the purpose of this hunk?
> 
>  //XXX: use a better typename
> +#ifndef ANDROID
>  typedef uint32_t __be32;
>  typedef uint16_t __be16;
> +#endif

Without it, we get:

/fasthome/mikew/moz/mozilla-central/gfx/qcms/iccread.c:29: error: redefinition of typedef '__be32'
/fasthome/mikew/moz/mc-droid-debug/../android-ndk-r3/build/platforms/android-5/arch-arm/usr/include/linux/types.h:24: note: previous declaration of '__be32' was here
/fasthome/mikew/moz/mozilla-central/gfx/qcms/iccread.c:30: error: redefinition of typedef '__be16'
/fasthome/mikew/moz/mc-droid-debug/../android-ndk-r3/build/platforms/android-5/arch-arm/usr/include/linux/types.h:22: note: previous declaration of '__be16' was here

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 436340 [details] [diff] [review]
Support building qcms on Android

It would be better to rename __be32/16 to be32/16 etc.

Comment 5

[Michael Wu [:mwu]]

Attachment: Support building qcms on Android, v2

Comment 6

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/481e63c694af