nsSearchService.restoreDefaultEngines should also restore the default order

NEW
Unassigned

Status

()

P5
normal
Rank:
51
9 years ago
3 years ago

People

(Reporter: whimboo, Unassigned)

Tracking

3.6 Branch
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [bug][fxsearch], URL)

(Reporter)

Description

9 years ago
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.3pre) Gecko/20100324 Namoroka/3.6.3pre ID:20100324033852

While implementing Mozmill tests for the search component I have noticed that the restoreDefaultEngines method of the SearchService doesn't restore the default order of the engines. There is also no other method available which offers that functionality in an easy way. Only the "Restore Defaults" button inside the Engine Manager resets everything. Means the sorting and hidden status of the engines get reset.

The code live here:
http://mxr.mozilla.org/mozilla-central/source/browser/components/search/content/engineManager.js#396

As Gavin told on IRC this logic should better be moved to the SearchService itself.
(Reporter)

Updated

9 years ago
Blocks: 556477
(Reporter)

Updated

6 years ago
Blocks: 834163
Points: --- → 2
Flags: qe-verify-
Flags: firefox-backlog+
Summary: nsSearchService.restoreDefaultEngines needs logic from Engine Manager → nsSearchService.restoreDefaultEngines should also restore the default order

Comment 1

4 years ago
defaults get restored and new search UI this should go away.  code in pref panel we believe restore order - but need to restore order.  low/no visible user impact
Rank: 51
Priority: -- → P5
Whiteboard: [bug]

Updated

4 years ago
Whiteboard: [bug] → [bug][fxsearch]
You need to log in before you can comment on or make changes to this bug.