556443 - Add support for building NSS on Android

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Michael Wu [:mwu]]

Attachment: Add support for building NSS on Android

Clearly android_stub.h can be put in a better place. I'm not sure where.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 436390 [details] [diff] [review]
Add support for building NSS on Android

>diff --git a/security/manager/Makefile.in b/security/manager/Makefile.in
>--- a/security/manager/Makefile.in
>+++ b/security/manager/Makefile.in
>@@ -285,6 +285,17 @@ DEFAULT_GMAKE_FLAGS += \
> 	$(NULL)
> endif
> 
>+# Android has pthreads integrated into -lc

Can you clarify this comment? Is this why you override OS_LIBS= ?

>diff --git a/security/manager/android_stub.h b/security/manager/android_stub.h
>new file mode 100644

Could you put a comment block at the top of this file to indicate its purpose? I'm guessing it's just stubbing out some library functions that you don't have, to avoid modifying NSS directly.

I also don't know that it belongs in security/manager directly, but I don't have a better idea, so I guess just leave it there unless someone has a better suggestion.

r=me with those fixes.

Comment 3

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/88665558c3e0