556458 - Cannot select an item of google suggest by mouse click during composition of MS-IME

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away until 6/30 except 24)]

Attachment: Patch v1.0

This is a regression of bug 492233.

When I click a text node of an item of google suggest during composition of MS-IME, the item isn't set to the input field.

This is a bug of nsContentEventHandler::OnQueryCharacterAtPoint(). It's looking for the target text frame at the click event but it doesn't check whether the text node is in the focused editor or not.

I think that this should be fixed on Fx3.6 too.

I'll create tests...

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away until 6/30 except 24)]

Attachment: Patch v1.0 + tests

Just adding to check whether the text node which is content of the found textframe is descendant of mRootContent (editor root) or not.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away until 6/30 except 24)]

http://hg.mozilla.org/mozilla-central/rev/489fde3195cd

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away until 6/30 except 24)]

Attachment: Patch v1.0 for 1.9.2 branch

This is a regression on major service and this patch doesn't have risk, so, we should fix this bug on branch too.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 436638 [details] [diff] [review]
Patch v1.0 for 1.9.2 branch

a=beltzner for mozilla-1.9.2.4

Comment 5

[Al Billings [:abillings - ex-MoCo]]

Masayuki, can you check your test into 1.9.2 as well? I don't see it in your 1.9.2 patch.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away until 6/30 except 24)]

(In reply to comment #5)
> Masayuki, can you check your test into 1.9.2 as well? I don't see it in your
> 1.9.2 patch.

The tests need new APIs, so, we cannot port the tests to 1.9.2 branch.