556573 - OpenGL video support doesn't support non-multiple-of-4 widths/heights

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Joe Drew (not getting mail)]

Playing the Big Buck Bunny 480p video results in the linked image's results when we switch to fullscreen OpenGL video. We're just off by a couple of pixels here because the image isn't a multiple of four.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Use GL_UNPACK_ALIGNMENT instead of ROW_LENGTH

We now look for the optimal alignment we've got. And then use GL_UNPACK_ALIGNMENT, in theory this should also work on OGL ES unlike the ROW_LENGTH approach.

Comment 2

[Joe Drew (not getting mail)]

Comment on attachment 436536 [details] [diff] [review]
Use GL_UNPACK_ALIGNMENT instead of ROW_LENGTH

Add comments saying what textures' alignments are being set at each PixelStore call, and one saying "restore to default" at the bottom of the function?

Comment 4

[Bas Schouten (:bas.schouten)]

Pushed http://hg.mozilla.org/mozilla-central/rev/3bce11a17af7.