5566 - 4.27.99 Mac builds lacks Spiffy New Icon Resources

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Eli Goldberg]

* TITLE/SUMMARY
4.27.99 Netscape Commercial build lacks sfraser's Spiffy New Icon Resources

* GENERAL FOO
Lord Fraser has informed me that the 4.27.99 Mac OS build (netscape5-mac) doesn't
have the Spiffy New Icon Resources (tm) that he did over the weekend, and thus,
has the old icon set.

[Haven't checked the Mozilla build, but am about to.]

Thanks!

Comment 1

[Eli Goldberg]

[This also applies to the Mozilla build, too, of the same date. Corrected title.
Thanks!]

Comment 2

[Simon Fraser [no longer active]]

Huh? If the mozilla build lack the icons too, something is really wrong. JJ, what
Apprunner project are you using for the mozilla build?

M5, just so we get the icons for the M5 build.

Comment 3

[J.J. Enser]

I can see the icons on the Mac that produces the daily build...
Eli, you might want to try and rebuild your desktop.

both apprunner.mcp project I use for mozilla & commerical builds include the
nsMacBundle.rsrc file, which I believe contains the new icons.

Comment 4

[Eli Goldberg]

Hmm...I rebuilt the desktop, and it's still using default icons. Sorry!

Comment 5

[J.J. Enser]

Mea culpa. The verification build didn't have the icons in it, because the
resource file that contains them had a bad type/creator.
sfraser has checked in a fix and I have verified it.

next spin will show the correct bundle / icon resources.
marking fixed.

-- note: public & commercial builds currently have identical creator and icons.
This will be changed after M5.

Comment 6

[Eli Goldberg]

This appears fixed in today's build, excepting 3 files which didn't inherit the
new icons. (E-mailed the names to Simon.)

Comment 7

[J.J. Enser]

I fixed all 3 of them earlier today.

Comment 8

[Eli Goldberg]

QA Assigning to self for verification.

Comment 9

[Eli Goldberg]

Verified fixed in 6.16.99 AM commercial Mac OS build (sfraser confirms mozilla
build is okay, too.)