556673 - spurious block in toolkit/components/Makefile.in prevents distclean from working properly

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[philippe (part-time)]

Attachment: distclean failure log

When building Camino based on gecko 1.9.2:
make -f client.mk distclean ends in failure (see attached log, with distclean -w)

affected block (on gecko 1.9.2):
ifeq ($(MOZ_BUILD_APP),camino)
DIRS += autocomplete/public
DIRS += downloads/public
endif

removing the block fixes the issue (successful distclean - and successful build afterwards)

m-c version:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/Makefile.in#123

Comment 1

[philippe (part-time)]

Attachment: patch that fixes the issue (gecko 1.9.2)

Comment 2

[philippe (part-time)]

Attachment: patch that fixes the issue (gecko 1.9.2)

with extra lines removed

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(These are leftovers from the bad old days of trying to remove xpfe/components; now that Camino builds "all" of toolkit/components by default, all this block does is make us try to delete Makefiles a second time during distclean, after the main portion of the file has handled them.)

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 436628 [details] [diff] [review]
patch that fixes the issue (gecko 1.9.2)

Obviously this needs to land on mozilla-central before it can go to 1.9.2.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/mozilla-central/rev/ef7261b4a589 (but with the bug number of an orange I was starring instead of the number for this bug :( )

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 436628 [details] [diff] [review]
patch that fixes the issue (gecko 1.9.2)

Requesting branch approval; this is a trivial patch that just removes an unneeded Camino-only block which breaks distcleans for Camino. It does not affect any other product.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 436628 [details] [diff] [review]
patch that fixes the issue (gecko 1.9.2)

a=beltzner for 1.9.1.10 and 1.9.2.4; Al, no verification needed

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/19b16993e7ec
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9cf3a3e0d7c1