spurious block in toolkit/components/Makefile.in prevents distclean from working properly

RESOLVED FIXED

Status

()

Toolkit
Build Config
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: philippe (part-time), Assigned: philippe (part-time))

Tracking

unspecified
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(status1.9.2 .4-fixed, status1.9.1 .10-fixed)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 436624 [details]
distclean failure log

When building Camino based on gecko 1.9.2:
make -f client.mk distclean ends in failure (see attached log, with distclean -w)

affected block (on gecko 1.9.2):
ifeq ($(MOZ_BUILD_APP),camino)
DIRS += autocomplete/public
DIRS += downloads/public
endif

removing the block fixes the issue (successful distclean - and successful build afterwards)

m-c version:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/Makefile.in#123
(Assignee)

Comment 1

7 years ago
Created attachment 436626 [details] [diff] [review]
patch that fixes the issue (gecko 1.9.2)
(Assignee)

Comment 2

7 years ago
Created attachment 436628 [details] [diff] [review]
patch that fixes the issue (gecko 1.9.2)

with extra lines removed
Attachment #436626 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Attachment #436628 - Flags: review?(ted.mielczarek)
(These are leftovers from the bad old days of trying to remove xpfe/components; now that Camino builds "all" of toolkit/components by default, all this block does is make us try to delete Makefiles a second time during distclean, after the main portion of the file has handled them.)
Assignee: nobody → phiw
Comment on attachment 436628 [details] [diff] [review]
patch that fixes the issue (gecko 1.9.2)

Obviously this needs to land on mozilla-central before it can go to 1.9.2.
Attachment #436628 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/ef7261b4a589 (but with the bug number of an orange I was starring instead of the number for this bug :( )
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Comment on attachment 436628 [details] [diff] [review]
patch that fixes the issue (gecko 1.9.2)

Requesting branch approval; this is a trivial patch that just removes an unneeded Camino-only block which breaks distcleans for Camino. It does not affect any other product.
Attachment #436628 - Flags: approval1.9.2.4?
Attachment #436628 - Flags: approval1.9.1.10?
Attachment #436628 - Flags: approval1.9.2.4?
Attachment #436628 - Flags: approval1.9.2.4+
Attachment #436628 - Flags: approval1.9.1.10?
Attachment #436628 - Flags: approval1.9.1.10+
Comment on attachment 436628 [details] [diff] [review]
patch that fixes the issue (gecko 1.9.2)

a=beltzner for 1.9.1.10 and 1.9.2.4; Al, no verification needed
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/19b16993e7ec
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9cf3a3e0d7c1
status1.9.1: --- → .10-fixed
status1.9.2: --- → .4-fixed
You need to log in before you can comment on or make changes to this bug.