Closed Bug 556710 Opened 14 years ago Closed 14 years ago

Make mpLocked part of Utils

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: zpao, Assigned: mconnor)

Details

Attachments

(1 file)

I've been using it places outside of Service, so we should move it.
Flags: blocking-weave1.3+
Attached patch v1Splinter Review
zpao's patch changed, but I still want this in Utils (it's a generic utility function).  We'll need to write a test for this, but since we depend on this in a couple of places, that's okay with me.
Assignee: nobody → mconnor
Status: NEW → ASSIGNED
Attachment #437735 - Flags: review?(edilee)
Whiteboard: [has patch][needs review Mardak]
Comment on attachment 437735 [details] [diff] [review]
v1

(In reply to comment #0)
> I've been using it places outside of Service, so we should move it.
The code eventually got moved into services, yes? At least I don't see any other uses or references to master password stuff elsewhere.
Attachment #437735 - Flags: review?(edilee) → review+
Whiteboard: [has patch][needs review Mardak] → [has patch][has review]
http://hg.mozilla.org/labs/weave/rev/c3c1dd704308
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review]
Target Milestone: 1.3 → 1.3b1
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: