Closed
Bug 556710
Opened 14 years ago
Closed 14 years ago
Make mpLocked part of Utils
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
1.3b1
People
(Reporter: zpao, Assigned: mconnor)
Details
Attachments
(1 file)
2.38 KB,
patch
|
Mardak
:
review+
|
Details | Diff | Splinter Review |
I've been using it places outside of Service, so we should move it.
Assignee | ||
Updated•14 years ago
|
Flags: blocking-weave1.3+
Assignee | ||
Comment 1•14 years ago
|
||
zpao's patch changed, but I still want this in Utils (it's a generic utility function). We'll need to write a test for this, but since we depend on this in a couple of places, that's okay with me.
Assignee | ||
Updated•14 years ago
|
Whiteboard: [has patch][needs review Mardak]
Comment 2•14 years ago
|
||
Comment on attachment 437735 [details] [diff] [review] v1 (In reply to comment #0) > I've been using it places outside of Service, so we should move it. The code eventually got moved into services, yes? At least I don't see any other uses or references to master password stuff elsewhere.
Attachment #437735 -
Flags: review?(edilee) → review+
Updated•14 years ago
|
Whiteboard: [has patch][needs review Mardak] → [has patch][has review]
Assignee | ||
Comment 3•14 years ago
|
||
http://hg.mozilla.org/labs/weave/rev/c3c1dd704308
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review]
Assignee | ||
Updated•14 years ago
|
Target Milestone: 1.3 → 1.3b1
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•