556826 - Having to many tabs opening seems to be OOM crashing my whole Firefox session [@ nsDOMClassInfo::PreCreate]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[danacon]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 (.NET CLR 3.5.30729)

Having to many tabs opening seems to be crashing my whole Firefox session. I like to open a lot of tabs in Firefox from multi places and it seems once I get up 95+ tabs Firefox gets more and more unstable until it just randomly crashes sometimes 110 tabs and I get crashes and it has to be restarted. 
This is very annoying.
Have you tried to make it so each tab works on its own per say so if one tab crashes it will not bring down the whole program?
It has happened multi times per day and sometimes I lose a lot of work in the progress. I love Firefox and want to continue to use but this is getting bad.

The crashes are random meaning anyone thing does not make it crash as different programs are open in the background and such every time.

95% of the time when it crashes I have 100+ tabs up and I will go to open another tab or open a tab that was already opened and it slows down  to not responding very unstable until it crashes or it will just crash without notice, but once it becomes unstable from a tab different one each time I can do nothing to save my work and bam its down.

Reproducible: Sometimes

Steps to Reproduce:
1.I have 100+ tabs open
2.go to open another tab from Thunderbird or maybe open to many tabs at one time clicking on links.
3.Or just switching to another tab while already in Firefox it becomes unstable and crashes or just crashes right away.


Expected Results:  
The software should not totally crash because I have to many tabs opened at one time and open another tab or switch from one tab to the next. It seems like one tab becoming unstable will bring down the whole program.

Comment 1

[danacon]

To many tabs just seem to cause unstable program, and causes crashes randomly. 
Shouldn't each tab be running on its own so if one goes down one doesn't lose there whole list and data?

crashreportid  are always sent in nothing is being done.

Comment 2

[Matthias Versen [:Matti]]

>Shouldn't each tab be running on its own so if one goes down one doesn't lose
>there whole list and data?
Currently not.

>crashreportid  are always sent in nothing is being done.
Post a crash ID ( https://developer.mozilla.org/en/How_to_get_a_stacktrace_for_a_bug_report )

Comment 3

[Miroslav Policki]

I confirm this. I have about 350 tabs open and Firefox crashes around once per day. One time when I had over 400 tabs open Firefox crashed much more frequently.

Steps to reproduce the bug:
1. Open a web page in a new tab.
2. Repeat step 1 until Firefox crashes.

Some of my crash IDs:
bp-a8631560-213c-4a80-9315-931ea2100328
bp-3e0c8039-7d41-4ffa-a2df-344af2100401
bp-a4acf483-bf6d-4b46-8531-57f062100403

Comment 4

[Tyler Downer [He/Him]]

Miroslav, your crashes are [@ xul.dll@0x18268c ]. Update to 3.6.3, and if you still see it, create a new bug.

Comment 5

[danacon]

Here is a crash report that just happened I had about 140 tabs opened and all my addons are up to date:

Add-ons: [e-mail]:1.2.5,{0545b830-f0aa-4d7e-8820-50a4629a56fe}:4.3,[e-mail]:2.23b1,{20a82645-c095-46ed-80e3-08825760534b}:1.1,{37E4D8EA-8BDA-4831-8EA1-89053939A250}:3.0.0.1,[e-mail]:1.3,{F645A8C9-E969-42D9-B3F3-F325537222FD}:1.1.6,[e-mail]:2.0.3,{EF522540-89F5-46b9-B6FE-1829E2B572C6}:4.2,{1280606b-2510-4fe0-97ef-9b5a22eafe30}:0.6.7.4,tabcounter@morac:1.8.4,{7A074BE0-2326-436d-B473-029FAEBEB5C6}:1.1.4,[e-mail]:1.1.5,[e-mail]:3.5.10,[e-mail]:0.5.10,{3f963a5b-e555-4543-90e2-c3908898db71}:9.0.0.783,[e-mail]:2.2.1,tito@sorttabs:2.100228.13,[e-mail]:1.7.0,[e-mail]:1.1,{CAFEEFAC-0016-0000-0016-ABCDEFFEDCBA}:6.0.16,{CAFEEFAC-0016-0000-0017-ABCDEFFEDCBA}:6.0.17,{972ce4c6-7e08-4474-a285-3208198ce6fd}:3.6.3
BuildID: 20100401080539
CrashTime: 1270678062
EMCheckCompatibility: true
Email: [e-mail]
FramePoisonBase: 00000000f0de0000
FramePoisonSize: 65536
InstallTime: 1270232001
ProductName: Firefox
ReleaseChannel: release
SecondsSinceLastCrash: 167736
StartupTime: 1270568523
Theme: classic/1.0
Throttleable: 1
URL: http://en.wikipedia.org/wiki/Hydromorphone
Vendor: Mozilla
Version: 3.6.3

This report also contains technical information about the state of the application when it crashed.

Comment 6

[Wayne Mery (:wsmwk)]

do you crash with firefox started in safe mode?
 http://support.mozilla.com/kb/Safe+Mode

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

CONFIRMED on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100430 Minefield/3.7a5pre

When I open about +500 tabs in one go, Firefox will crash or will forced close without any info, when simply Fx will exceed system memory...
I have 2GB RAM and when Fx will be near to consume all memory, crash will happen

this should be marked as BLOCKER IMO...

Comment 8

[Tyler Downer [He/Him]]

bernesB, please try with a fresh profile, and give a stacktrace. No, it isn't a blocker.

Comment 9

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Fresh profile, safe mode etc... all fails
I also tried to get crashdump, but I cant now, cause it happens only sometimes
and mostly Fx will close without any info or Crash Reporter

but you should reproduce it very easily, just open +1000 tabs in one go and you can see it

p.s. I got 1 crash on start, but its probably not related to this bug, cause crash happens when RAM is fully eaten by Fx
http://crash-stats.mozilla.com/report/index/bp-c999ad6d-b1cb-4799-9aa8-6fb452100430

Comment 10

[timeless]

Signature	nsDOMClassInfo::PreCreate(nsISupports*, JSContext*, JSObject*, JSObject**)
UUID	c999ad6d-b1cb-4799-9aa8-6fb452100430
Time 	2010-04-30 12:02:49.213510
Uptime	29
Product	Firefox
Version	3.7a5pre
Build ID	20100429041232
Branch	1.9.3
OS	Windows NT
OS Version	5.1.2600 Dodatek Service Pack 3
CPU	x86
CPU Info	GenuineIntel family 6 model 15 stepping 11
Crash Reason	EXCEPTION_ACCESS_VIOLATION
Crash Address	0x34
User Comments	crash when opening more +500 tabs
Crashing Thread
Frame 	Module 	Signature [Expand] 	Source
0 	xul.dll 	nsDOMClassInfo::PreCreate 	dom/base/nsDOMClassInfo.cpp:4052
1 	xul.dll 	XPCWrappedNative::GetNewOrUsed 	js/src/xpconnect/src/xpcwrappednative.cpp:438
2 	xul.dll 	XPCConvert::NativeInterface2JSObject 	js/src/xpconnect/src/xpcconvert.cpp:1202
3 	xul.dll 	XPCConvert::NativeData2JS 	js/src/xpconnect/src/xpcconvert.cpp:471
4 	xul.dll 	XPCConvert::NativeData2JS 	js/src/xpconnect/src/xpcprivate.h:3025
5 	xul.dll 	XPC_WN_GetterSetter 	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1814
6 	mozjs.dll 	js_Invoke 	js/src/jsinterp.cpp:834
7 	mozjs.dll 	js_InternalInvoke 	js/src/jsinterp.cpp:899
8 	mozjs.dll 	JS_CallFunctionValue 	js/src/jsapi.cpp:4945
9 	xul.dll 	XPCWrapper::GetOrSetNativeProperty 	js/src/xpconnect/src/XPCWrapper.cpp:881
10 	xul.dll 	XPC_NW_GetOrSetProperty 	js/src/xpconnect/src/XPCNativeWrapper.cpp:657
11 	xul.dll 	nsIDOMNode_GetChildNodes 	obj-firefox/js/src/xpconnect/src/dom_quickstubs.cpp:5126
12 	xul.dll 	XPC_NW_GetProperty 	js/src/xpconnect/src/XPCNativeWrapper.cpp:663

Comment 11

[timeless]

4050 if (piwin->IsOuterWindow()) {
4051 *parentObj = ((nsGlobalWindow *)piwin.get())->
4052 GetCurrentInnerWindowInternal()->GetGlobalJSObject(); 

I *think* piwin is null.

Comment 12

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

bump, bug still exist...

can some1 mark this COMFIRMED or at last test this on his side (opening many tabs to consume all of RAM to see it)
not only asking for crashlogs, which cant be simply obtained

Comment 13

[danacon]

Well I am still having the crash problem, I have 6GB ram and the crashes seem quite random but only happens when I have 100+ tabs opened. at 100+ tabs Firefox is using a good chunk of memory like 1.3-1.5gb of my total ram but I always have some left.  I am about to do a new profile and install, see what happens.
Also start safe mode and with no addons installed or on rather, I have just been very busy and have not gotten a chance to do all that.
 But like I said I am still getting random Firefox crashes with large number of tabs opened.
 Is there anything specific you would like me to do when I am trouble shooting what is going on when it crashes? The more things to look for and or do the better?
Thanks again and I know I am not the only one having this problem but my crashes happen between 95 - 145 tabs and I do not like going any higher than that. I am using windows 7 64bit.

Comment 14

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

BUMPing 1 more time, cause bug still is reproducible on fresh install & new profile without addons...

Can some1 form dev team finally look into it ? Cause it's serious problem...

Comment 15

[Wayne Mery (:wsmwk)]

I think we should refocus on danacon's issue.  Firstly, danacon, please post crash report ids for some of your crashes.  https://support.mozilla.com/en-US/kb/Mozilla+Crash+Reporter?s=crash report#Viewing_crash_reports - then we can consider confirming the bug report.

If danacon's crash sig is different then other people will need to file new bugs.

Some general comments relating to using 100s of tabs:

1. At 200-300+ tabs, and depending on usage pattern, one starts bumping into windows limitations. one example: gdi objects per process is limited to 10,000 but in my experience FF (and OS) slowness and crashes are likely when you get in the 8,000+ range.  At 500 tabs you are almost guaranteed to have problems with windows limitations.  Plus, you probably have bad session restore performance.  
http://en.wikipedia.org/wiki/Graphics_Device_Interface
http://msdn.microsoft.com/en-us/library/ms724291%28VS.85%29.aspx
http://blogs.technet.com/b/markrussinovich/archive/2010/03/31/3322423.aspx
http://msdn.microsoft.com/en-us/library/aa366778%28VS.85%29.aspx

2. despite the improvements of the past couple years, FF still suffers garbage collectiton and other performance issues, whose effects are greatly magnified when using hundreds of tabs.

3. Pages with certain types of js can make things worse

In short, I'd be shocked if  BernesB didn't have crashes, and is likely hitting windows limitations and experiencing firefox OOM.  However, danacon probably should not be seeing crashes.

Comment 16

[danacon]

I am the original poster.
  I just updated to the latest Firefox 3.6.6 2 -3 weeks ago and since then I have not had this problem for a while seems since I did the update. where it use to happen daily to every 2 days, I can now open 100+ tabs at once and I get no crash, once in a while I will get a slowdown but it starts responding again within a few seconds. I am not sure what was causing it, but so far everything seems ok. I am not sure with other people is still having this problem.
 Sorry I didn't give you any more information on the subject I have been very busy after my first couple posts and didn't get time to do much trouble shooting on it just safe mode and some addon tests.

Comment 17

[danacon]

I also think a lot of the crashes may have been due to js and other type plugins on certain web pages, hard to tell when you have 100+ tabs opened at same time, and no time to go through them all...

Comment 18

[timeless]

Attachment: proposal

well, i clearly didn't read enough of the context :(

the rest of this file seems fairly concerned that innerwindow might be null.

Comment 19

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 459144 [details] [diff] [review]
proposal

This will result in objects being parented to the outer window, which is Bad (TM). We need to figure out how code is running and creating objects on an outer window that has no inner.

FWIW, I have a couple of patches in flight that might actually fix that problem.

Comment 20

[Johnny Stenback (:jst)]

Seems like these crashes are due to out of memory. If the people who are seeing this are running the standard 32-bit versions of Firefox (Mozilla has never shipped any other versions fwiw) then even if you have 6 gigs of ram (or more) windows still limits the address space of the 32-bit firefox process to 2 gigs (same goes for any 32-bit app, it's a windows limitation), so if you're running at 1.5 gigs+ of memory usage we may very well run into allocation failures which can lead to a crash either right there or at some later point if the errors don't propagate out properly etc.

While I would love to see this fixed, I don't think we can block on this.

Comment 21

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Opening many tabs (>500) causing Fx to close and this error appears
http://img176.imageshack.us/img176/6228/27539105.png

Comment 22

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

No news about patch ?

Comment 23

[Wayne Mery (:wsmwk)]

mrbkap, any further thoughts on comment 19?

to go with jst's comment 20 ... windows users might have a look at windows' taskmgr GDI count for firefox.exe next time you have this many tabs open. There is a per-task limit if 10k for GDI objects, and my experience is FF typically starts becoming unstable in the 5-7k range,  even though FF isn't using anywhere close to the 2GB 32bit process limit.


virtual_manpl, your issue is not this bug afaict

Comment 24

[therube]

My Bug 641164 - sessionrestore crash on startup, shows aspects of both mentioned Windows limitations; the memory issue & the GDI issue.

Comment 25

[Wayne Mery (:wsmwk)]

(In reply to Blake Kaplan (:mrbkap) from comment #19)
> Comment on attachment 459144 [details] [diff] [review]
> proposal
> 
> This will result in objects being parented to the outer window, which is Bad
> (TM). We need to figure out how code is running and creating objects on an
> outer window that has no inner.
> 
> FWIW, I have a couple of patches in flight that might actually fix that
> problem.

Blake are those ideas still valid 2 years later?

Comment 26

[Blake Kaplan (:mrbkap) (inactive)]

Bug 838182 removed the code that was crashing here, so marking this as fixed. It's likely that this case will still crash in other places (especially now that most of our allocations crash if they fail) but this crash at least should be fixed.