Closed
Bug 556831
Opened 14 years ago
Closed 14 years ago
nsMsgDBView::IsValidIndex() unncessarily checks if unsigned int is < 0
Categories
(MailNews Core :: Database, defect)
MailNews Core
Database
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.1b2
People
(Reporter: mkmelin, Assigned: mkmelin)
Details
Attachments
(1 file, 1 obsolete file)
|
765 bytes,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
From bug 288172 comment 3, nsMsgDBView::IsValidIndex() unncessarily checks if unsigned int is < 0 (http://mxr.mozilla.org/comm-central/source/mailnews/base/public/MailNewsTypes2.idl#39)
Attachment #436722 -
Flags: superreview?(bienvenu)
Attachment #436722 -
Flags: review?(bienvenu)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 436722 [details] [diff] [review] proposed fix thx for filing this, and for the patch. I'd like it to also check that index is not nsMsgViewIndex_None...
Attachment #436722 -
Flags: superreview?(bienvenu)
Attachment #436722 -
Flags: superreview-
Attachment #436722 -
Flags: review?(bienvenu)
Attachment #436722 -
Flags: review-
|
Assignee | |
Comment 2•14 years ago
|
||
Checking nsMsgViewIndex_None too.
Attachment #436722 -
Attachment is obsolete: true
Attachment #436730 -
Flags: superreview?(bienvenu)
Attachment #436730 -
Flags: review?(bienvenu)
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 436730 [details] [diff] [review] proposed fix, v2 thx, Magnus.
Attachment #436730 -
Flags: superreview?(bienvenu)
Attachment #436730 -
Flags: superreview+
Attachment #436730 -
Flags: review?(bienvenu)
Attachment #436730 -
Flags: review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
changeset: 5369:64734d6f52f2 http://hg.mozilla.org/comm-central/rev/64734d6f52f2 ->FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•