556948 - suspend NSPR test fails on Android

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Alex Pakhotin (:alexp)]

The "suspend" test crashes with Segmentation fault.

Comment 1

[Alex Pakhotin (:alexp)]

Attachment: Fix

Check for NULL the result returned by PR_GetGCRegisters().

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

wouldn't it be better to implement _MD_HomeGCRegisters for android?

Comment 3

[Alex Pakhotin (:alexp)]

As far as I understand, _MD_HomeGCRegisters seems to do something and return the array of the registers only if _PR_PTHREADS is not defined, i.e. USE_PTHREADS config setting is not set to 1.
If someone could clarify what those definitions mean, and if this function is important, then we could decide what to do with this.

In any case I think the test has to check the returned pointer before using it, as it's possible that the function may return NULL.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 436823 [details] [diff] [review]
Fix

over to Wan-Teh

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 436823 [details] [diff] [review]
Fix

Since Wan-Teh hasn't gotten to this yet I'm moving the review to ted

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 436823 [details] [diff] [review]
Fix

Given the behavior of _MD_HomeGCRegisters, this seems fine.

Comment 7

[(not currently active) Ted Mielczarek]

Committed to NSPR CVS:
Checking in pr/tests/suspend.c;
/cvsroot/mozilla/nsprpub/pr/tests/suspend.c,v  <--  suspend.c
new revision: 3.11; previous revision: 3.10
done