suspend NSPR test fails on Android

RESOLVED FIXED in 4.8.7

Status

NSPR
NSPR
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: alexp, Assigned: alexp)

Tracking

other
4.8.7
ARM
Android

Firefox Tracking Flags

(fennec-)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
The "suspend" test crashes with Segmentation fault.
(Assignee)

Updated

8 years ago
Assignee: wtc → alexp
Status: NEW → ASSIGNED
(Assignee)

Comment 1

8 years ago
Created attachment 436823 [details] [diff] [review]
Fix

Check for NULL the result returned by PR_GetGCRegisters().
Attachment #436823 - Flags: review?(bugmail)
wouldn't it be better to implement _MD_HomeGCRegisters for android?
(Assignee)

Comment 3

8 years ago
As far as I understand, _MD_HomeGCRegisters seems to do something and return the array of the registers only if _PR_PTHREADS is not defined, i.e. USE_PTHREADS config setting is not set to 1.
If someone could clarify what those definitions mean, and if this function is important, then we could decide what to do with this.

In any case I think the test has to check the returned pointer before using it, as it's possible that the function may return NULL.
Comment on attachment 436823 [details] [diff] [review]
Fix

over to Wan-Teh
Attachment #436823 - Flags: review?(bugmail) → review?(wtc)
Comment on attachment 436823 [details] [diff] [review]
Fix

Since Wan-Teh hasn't gotten to this yet I'm moving the review to ted
Attachment #436823 - Flags: review?(wtc) → review?(ted.mielczarek)
tracking-fennec: --- → ?
Attachment #436823 - Flags: review?(ted.mielczarek) → review?(wtc)
Attachment #436823 - Flags: review?(wtc) → review?(ted.mielczarek)
Comment on attachment 436823 [details] [diff] [review]
Fix

Given the behavior of _MD_HomeGCRegisters, this seems fine.
Attachment #436823 - Flags: review?(ted.mielczarek) → review+

Updated

8 years ago
tracking-fennec: ? → 2.0-
Keywords: checkin-needed
Committed to NSPR CVS:
Checking in pr/tests/suspend.c;
/cvsroot/mozilla/nsprpub/pr/tests/suspend.c,v  <--  suspend.c
new revision: 3.11; previous revision: 3.10
done
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Keywords: checkin-needed

Updated

7 years ago
Target Milestone: --- → 4.8.7
You need to log in before you can comment on or make changes to this bug.