557011 - [OOPP] [Mac] Killing mozilla-runtime process results in browser crashing [@ CrashReporter::TakeMinidumpForChild(unsigned int, nsILocalFile**) ]

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Alex]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a4pre) Gecko/20100403 Minefield/3.7a4pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a4pre) Gecko/20100403 Minefield/3.7a4pre

With OOPP enabled (and all plugins except for Flash disabled), killing the mozilla-runtime process results in the browser process also crashing.

http://crash-stats.mozilla.com/report/index/bp-af4d62ad-305c-43f3-9dc7-236a32100403

Reproducible: Always

Comment 1

[Marcia Knous [:marcia]]

Confirming, but in my case I did not have any plugins disabled and I did not kill the runtime process. Here are my STR on my 10.5. laptop:

STR:
1. Using an existing profile launch Minefield and flip the preference.
2. Restart Minefield. It tries to restore my tabs but crashes in this stack.
3. I see another instance of Minefield appear briefly in the dock shortly before the crash.

http://crash-stats.mozilla.com/report/index/42c41981-ba33-45e6-ae7a-1d3a32100403 is my report and I am using Version: 10.0.45.2 of Flash.

Comment 2

[Josh Aas]

We do not support OOPP on Mac OS X 10.5, at least for now. We disabled it today.

Comment 3

[Marcia Knous [:marcia]]

Sorry I forgot 10.5 was not supported - but it looks as if the reporter was getting the crash using 10.6. I can check when I have my 10.6 machine available.

Comment 4

[philippe (part-time)]

I get that crash on 10.6.3 with Flash 10.1b3
http://crash-stats.mozilla.com/report/index/13a39998-1c38-4694-8680-949b82100403

str:
1. view youTube movie
2. second process launches, 2nd Minefield icon bounces and bounces in the dock
2a. Activity Monitor reports the process as not responding (but the movie plays)
3. force quit the process from Activity Monitor

AR: crash (the whole Minefield, all 2 processes).

I'll attach a hang generated by the Apple report utility.

Comment 5

[philippe (part-time)]

Attachment: Minefield hang

generated by the Apple Report utility, per comment 4.

Comment 6

[Benoit Girard (:BenWa)]

I have been building with crash reporter disabled. This must be why I can not reproduce it.

According to bug 555714 crashreporter should be disabled for 32-bit builds on OS X. Perhaps the patch missed something.

Comment 7

[d]

I got this when having OOPP enabled and visiting a site with the Flash plugin. A new Minefield logo appeared in the dock, and just as it was about to stop bouncing, Minefield crashed. This happened every time I restarted and restored the session.

(Note: In other words, I did not kill the plugin myself.)

Comment 8

[(no longer active)]

With regard to comment 2, if this is not known already, this crash happens on OS X 10.6 with the latest nightly as well.  It's reliably reproducible.

Comment 9

[RC]

Yup. Happening 100% of the time for me.
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a4pre) Gecko/20100406 Minefield/3.7a4pre

Comment 10

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

FWIW I can't repro on 10.5, although I do see

WARNING: [PluginModuleParent::ActorDestroy] abnormal shutdown without minidump!: file /Users/cjones/mozilla/mozilla-central/dom/plugins/PluginModuleParent.cpp, line 269
JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsICrashReporter.submitReports]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame :: chrome://browser/content/browser.js :: anonymous :: line 8502"  data: no]

The "abnormal shutdown without minidump" is expected and benign, uncaught exception is not.

Comment 11

[(no longer active)]

(In reply to comment #10)
> JavaScript error: , line 0: uncaught exception: [Exception... "Component
> returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED)
> [nsICrashReporter.submitReports]"  nsresult: "0x80004001
> (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame ::
> chrome://browser/content/browser.js :: anonymous :: line 8502"  data: no]

The exception is coming from here:

http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/nsExceptionHandler.cpp#1096

Comment 12

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Ensure OOP crashreporter has been initialized in TakeMinidumpForChild()

I think this is the cause of the crash, but I don't know why I couldn't repro on 10.5.  Will give it another shot.

Comment 13

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Ensure OOP crashreporter has been initialized in TakeMinidumpForChild(), v2

Turns out I was repro'ing the crash, but didn't know it.  (Sorry, getting my mac-development sea legs.)

Comment 14

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Ensure OOP crashreporter has been initialized for mac, v3

Comment 15

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://hg.mozilla.org/mozilla-central/rev/56edf0b86593