Closed Bug 557012 Opened 15 years ago Closed 15 years ago

[Crashstats] Mozbot should accept both http:// and https:// links

Categories

(Webtools Graveyard :: Mozbot, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mozilla.bugs, Assigned: mozilla.bugs)

References

Details

Attachments

(1 file)

Attached patch Patch v. 1.0Splinter Review
Since we are using (?>!...), I can't add https? or (?:http|https). So I have dropped the protocol check, which means that ftp://crash-stats.mozilla.org/..., javascript://crash-stats.mozilla.org/..., etc. will not be linked; however, I don't think people will be reporting urls using those protocols anyway, and it's the only solution that I can figure out for the moment so that http and https are both ignored. Test output with patch applied to somethingbot: [11:00:31] <tmyoung> d38d7c4d-353f-425a-b8a9-c5fb22100226 [11:00:33] <firebot> tmyoung: http://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226 <somethingbot> tmyoung: http://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226 [11:00:39] <tmyoung> http://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226 [11:00:44] https://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226 [11:00:45] <firebot> tmyoung: http://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226 (Nothing from somethingbot)
Attachment #436871 - Flags: review?(bugtrap)
Blocks: 509863
Attachment #436871 - Flags: review?(bugtrap) → review+
Keywords: checkin-needed
Checking in Crashstats.bm; /cvsroot/mozilla/webtools/mozbot/BotModules/Crashstats.bm,v <-- Crashstats.bm new revision: 1.2; previous revision: 1.1 done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: