557012 - [Crashstats] Mozbot should accept both http:// and https:// links

Status: RESOLVED FIXED

Description

[Tanner M. Young [:tmyoung]]

[10:45:07]	<tmyoung>	https://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226
[10:45:11]	<firebot>	tmyoung: http://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226

Comment 1

[Tanner M. Young [:tmyoung]]

Created attachment 436871 [details] [diff] [review]
Patch v. 1.0

Since we are using (?>!...), I can't add https? or (?:http|https).  So I have dropped the protocol check, which means that ftp://crash-stats.mozilla.org/..., javascript://crash-stats.mozilla.org/..., etc. will not be linked; however, I don't think people will be reporting urls using those protocols anyway, and it's the only solution that I can figure out for the moment so that http and https are both ignored.

Test output with patch applied to somethingbot:

[11:00:31]	<tmyoung>       d38d7c4d-353f-425a-b8a9-c5fb22100226
[11:00:33]	<firebot>	tmyoung: http://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226
	<somethingbot>	tmyoung: http://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226
[11:00:39]	<tmyoung>	http://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226
[11:00:44]	https://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226
[11:00:45]	<firebot>	tmyoung: http://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226 
(Nothing from somethingbot)

Comment 2

[Wolf [:wolf]]

Checking in Crashstats.bm;
/cvsroot/mozilla/webtools/mozbot/BotModules/Crashstats.bm,v  <--  Crashstats.bm
new revision: 1.2; previous revision: 1.1
done