[Crashstats] Mozbot should accept both http:// and https:// links

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: mozilla.bugs, Assigned: mozilla.bugs)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Comment 1

9 years ago
Created attachment 436871 [details] [diff] [review]
Patch v. 1.0

Since we are using (?>!...), I can't add https? or (?:http|https).  So I have dropped the protocol check, which means that ftp://crash-stats.mozilla.org/..., javascript://crash-stats.mozilla.org/..., etc. will not be linked; however, I don't think people will be reporting urls using those protocols anyway, and it's the only solution that I can figure out for the moment so that http and https are both ignored.

Test output with patch applied to somethingbot:

[11:00:31]	<tmyoung>       d38d7c4d-353f-425a-b8a9-c5fb22100226
[11:00:33]	<firebot>	tmyoung: http://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226
	<somethingbot>	tmyoung: http://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226
[11:00:39]	<tmyoung>	http://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226
[11:00:44]	https://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226
[11:00:45]	<firebot>	tmyoung: http://crash-stats.mozilla.com/report/index/d38d7c4d-353f-425a-b8a9-c5fb22100226 
(Nothing from somethingbot)
Attachment #436871 - Flags: review?(bugtrap)
(Assignee)

Updated

9 years ago
Blocks: 509863

Updated

9 years ago
Attachment #436871 - Flags: review?(bugtrap) → review+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed

Comment 2

9 years ago
Checking in Crashstats.bm;
/cvsroot/mozilla/webtools/mozbot/BotModules/Crashstats.bm,v  <--  Crashstats.bm
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.