Closed Bug 557027 Opened 10 years ago Closed 10 years ago

fix single objdir --enable-mobile build to work on all platforms

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file, 1 obsolete file)

The attached patch fixes my desktop Fennec build with just --enable-application=mobile to link the fennec binary correctly.

As a bonus, it uses -rpath=$ORIGIN, so you can run the resulting fennec binary without a wrapper script. The NSDISTMODE=copy is because ld.so apparently uses the realpath of the binary to calculate $ORIGIN, and we normally symlink it into dist/bin.

I haven't tested this on a Maemo build or the other desktop platforms yet, I should make sure it works there first. If it works properly there, we should switch our official builds to just do --enable-application=mobile instead of the current two-pass xulrunner+mobile builds.
This works fine on Maemo. Still need to sanity check it on Windows/OS X.
Blocks: 557201
Works on Windows, broke on OS X. Should be simple enough to fix.
Ok, this works on desktop Linux/Windows/OS X and Maemo.
Attachment #436875 - Attachment is obsolete: true
Attachment #437039 - Flags: review?(bugmail)
Comment on attachment 437039 [details] [diff] [review]
Fix linkage, use -rpath=$ORIGIN, fix OS X non-libxul-sdk


>+	printf "APPLMOZB" > $(DIST)/$(APP_NAME).app/Contents/PkgInfo
> 
> else
> 

could you please put a comment like "# not OSX" after the else for readability?
Attachment #437039 - Flags: review?(bugmail) → review+
Pushed to m-b:
http://hg.mozilla.org/mobile-browser/rev/90ddd925cea3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.