557084 - Remove deprecated attributes and empty <mrow/>'s in mozilla/src/layout/mathml/tests/

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[Frédéric Wang (:fredw)]

Some test files in mozilla/src/layout/mathml/tests/ use attributes such that fontweight that are now deprecaded:
http://www.w3.org/TR/MathML3/chapter3.html#presm.deprecatt

Also, maxwell.xml contains some empty "<mrow></mrow>".

Comment 1

[Matthew M Levitt]

I would like to work on this, as my first summer volunteer project, for Mozilla.  What are the steps/requirements for this opportunity?

Comment 2

[Karl Tomlinson (:karlt)]

Thank you, Matthew.

This is about replacing the deprecated attributes with their preferred/newer notations.

The guides below are more oriented toward code changes but they give an idea of the process.  Even though you won't need to build the code for this bug, it will still be worthwhile obtaining the source from mercurial.

http://mdn.beonex.com/En/Developer_Guide/How_to_Submit_a_Patch
http://mdn.beonex.com/en/Creating_a_patch

Comment 3

[Frédéric Wang (:fredw)]

For the "<mrow></mrow>" in maxwell.xml, they are used as argument of a <munderover/> element. In that case, you can replace <munderover/> by <mover/> or <munder/> element and so remove the empty <mrow/>.
See the spec to understand how these mover, munder & munderover work:
http://www.w3.org/TR/MathML3/chapter3.html#presm.scrlim

Inferred <mrow>'s such that
http://mxr.mozilla.org/mozilla-central/source/layout/mathml/tests/maxwell.xml#225
can also be removed:
http://www.w3.org/TR/MathML3/chapter3.html#presm.inferredmrow

For the deprecated attributes, they are listed in the page I give above, as well as what to use instead. If you have a UNIX-like system, moving in layout/mathml/tests/ and calling a command like "grep -n fontstyle *" would help you to figure out where the deprecated attributes are located.
Note that the new attributes are now allowed on any MathML element, so something like
http://mxr.mozilla.org/mozilla-central/source/layout/mathml/tests/maxwell.xml#64
can be simply rewritten
<mi mathvariant='bold'>B</mi>

If you have any further questions, don't hesitate to ask here.
Good luck for your summer volunteer project!

Comment 4

[Jonathan Hage]

Attachment: Patch

Comment 5

[Frédéric Wang (:fredw)]

@karl: When this bug as well as bug 602828 are fixed, I wondering if we should just move all these non-automated tests online, as I don't think anyone uses them otherwise.

Comment 6

[Karl Tomlinson (:karlt)]

Yes, moving them online sounds good.

Comment 7

[Karl Tomlinson (:karlt)]

Comment on attachment 540248 [details] [diff] [review]
Patch

Are you able to look over this, please Frédéric?

Comment 8

[Jonathan Hage]

Attachment: Patch

Comment 9

[Frédéric Wang (:fredw)]

Comment on attachment 540411 [details] [diff] [review]
Patch

Review of attachment 540411 [details] [diff] [review]:
-----------------------------------------------------------------

OK, that looks good, thanks. There are only too remaining deprecated attributes here:

fred@debian:~/mozilla/src/layout/mathml/tests$ grep -n fontstyle *
mixing.xml:99:  <mi fontstyle="italic">jif</mi>
mixing.xml:100:  <mi fontstyle="italic">jif</mi>

r=me with these changes.

Comment 10

[Jonathan Hage]

Attachment: Patch version 2

Comment 11

[(no longer active)]

Landed on inbound.

Comment 12

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/5b5d90cdfccb