The default bug view has changed. See this FAQ.

Remove deprecated attributes and empty <mrow/>'s in mozilla/src/layout/mathml/tests/

RESOLVED FIXED in mozilla7

Status

()

Core
MathML
--
trivial
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: fredw, Assigned: Jonathan Hage)

Tracking

Trunk
mozilla7
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug], URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

7 years ago
Some test files in mozilla/src/layout/mathml/tests/ use attributes such that fontweight that are now deprecaded:
http://www.w3.org/TR/MathML3/chapter3.html#presm.deprecatt

Also, maxwell.xml contains some empty "<mrow></mrow>".

Comment 1

7 years ago
I would like to work on this, as my first summer volunteer project, for Mozilla.  What are the steps/requirements for this opportunity?
Thank you, Matthew.

This is about replacing the deprecated attributes with their preferred/newer notations.

The guides below are more oriented toward code changes but they give an idea of the process.  Even though you won't need to build the code for this bug, it will still be worthwhile obtaining the source from mercurial.

http://mdn.beonex.com/En/Developer_Guide/How_to_Submit_a_Patch
http://mdn.beonex.com/en/Creating_a_patch
(Reporter)

Comment 3

7 years ago
For the "<mrow></mrow>" in maxwell.xml, they are used as argument of a <munderover/> element. In that case, you can replace <munderover/> by <mover/> or <munder/> element and so remove the empty <mrow/>.
See the spec to understand how these mover, munder & munderover work:
http://www.w3.org/TR/MathML3/chapter3.html#presm.scrlim

Inferred <mrow>'s such that
http://mxr.mozilla.org/mozilla-central/source/layout/mathml/tests/maxwell.xml#225
can also be removed:
http://www.w3.org/TR/MathML3/chapter3.html#presm.inferredmrow

For the deprecated attributes, they are listed in the page I give above, as well as what to use instead. If you have a UNIX-like system, moving in layout/mathml/tests/ and calling a command like "grep -n fontstyle *" would help you to figure out where the deprecated attributes are located.
Note that the new attributes are now allowed on any MathML element, so something like
http://mxr.mozilla.org/mozilla-central/source/layout/mathml/tests/maxwell.xml#64
can be simply rewritten
<mi mathvariant='bold'>B</mi>

If you have any further questions, don't hesitate to ask here.
Good luck for your summer volunteer project!
(Reporter)

Updated

6 years ago
Assignee: nobody → hage.jonathan
(Assignee)

Comment 4

6 years ago
Created attachment 540248 [details] [diff] [review]
Patch
(Reporter)

Comment 5

6 years ago
@karl: When this bug as well as bug 602828 are fixed, I wondering if we should just move all these non-automated tests online, as I don't think anyone uses them otherwise.
Yes, moving them online sounds good.
Comment on attachment 540248 [details] [diff] [review]
Patch

Are you able to look over this, please Frédéric?
Attachment #540248 - Flags: review?(fred.wang)
(Assignee)

Comment 8

6 years ago
Created attachment 540411 [details] [diff] [review]
Patch
Attachment #540248 - Attachment is obsolete: true
Attachment #540248 - Flags: review?(fred.wang)
(Reporter)

Comment 9

6 years ago
Comment on attachment 540411 [details] [diff] [review]
Patch

Review of attachment 540411 [details] [diff] [review]:
-----------------------------------------------------------------

OK, that looks good, thanks. There are only too remaining deprecated attributes here:

fred@debian:~/mozilla/src/layout/mathml/tests$ grep -n fontstyle *
mixing.xml:99:  <mi fontstyle="italic">jif</mi>
mixing.xml:100:  <mi fontstyle="italic">jif</mi>

r=me with these changes.
Attachment #540411 - Flags: review+
(Assignee)

Comment 10

6 years ago
Created attachment 540702 [details] [diff] [review]
Patch version 2
Attachment #540411 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Reporter)

Updated

6 years ago
Status: NEW → ASSIGNED
Landed on inbound.
Keywords: checkin-needed
Pushed:
http://hg.mozilla.org/mozilla-central/rev/5b5d90cdfccb
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.