557133 - Conflict between Home Page and Help access keys (both H)

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Gids Goldberg]

Attachment: screenshot of general options tab

On the General options tab, the Home page and Help options both appear in the UI to have the same access key 'H'. 

Steps to Reproduce
------------------
Tools > Options > General Tab
Try to access Home Page field using access key (Alt + H)

Actual Results
---------------
Home Page and Help both share the same access key.
Focus is given to the Help button.

Expected Results
----------------
Help and Home Page should have different access keys.
Home Page access key should give focus to Home Page URL field.


Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100404 Minefield/3.7a4pre

Comment 1

[Tyler Downer [He/Him]]

Maybe should change it to P.

Comment 2

[Tyler Downer [He/Him]]

Attachment: Patch v1

Change accesskey to P, which does not seem like it is used.

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 436952 [details] [diff] [review]
Patch v1

My review queue is a tad long with the extension manager rewrite so I'm pushing this over to Dietrich.

btw: we typically change the entity name unless l10n approves not changing the entity name.

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 436952 [details] [diff] [review]
Patch v1

Thanks Tyler! 1) I'd prefer a letter that's in the word, if possible, and 2) check to see if you need to change the entity name, as Rob said. Could either post to the l10n newsgroup or ask [e-mail] for first-review.

Comment 5

[Tyler Downer [He/Him]]

Ah, so the P in Page won't work? Alright, I'll do that soon, finals coming up ;)

Comment 6

[Tyler Downer [He/Him]]

dietrich, ping.
Before I ask l10n , will the "p" in page work?

Comment 7

[Tyler Downer [He/Him]]

Possible blocking 4 as this pretty much makes it impossible to navigate to either Home page or Help in the options window. I know string freeze is tonight...

Comment 8

[Dietrich Ayala (:dietrich)]

P sounds fine to me, but the l10n people will have higher quality feedback. Create a new patch with P and the changed entity name (and changed where used) and ask feedback? from [e-mail].

Comment 9

[Dietrich Ayala (:dietrich)]

(In reply to comment #7)
> Possible blocking 4 as this pretty much makes it impossible to navigate to
> either Home page or Help in the options window. 

Can you elaborate? If we have conflicting access keys, you can't navigate to either?

Comment 10

[Tyler Downer [He/Him]]

No, you can't. Pressing Alt + H currently in the Options window does nothing, while pressing alt + S for example highlights "When Firefox starts:" So, essentially Home Page and Help are inaccessible

Comment 11

[Tyler Downer [He/Him]]

Attachment: Patch v2

Comment 12

[Axel Hecht [:Pike]]

Comment on attachment 475747 [details] [diff] [review]
Patch v2

This doesn't seem to be a regression, right?

Not sure if it's worth fixing at this point, though I'm also not sure if it's worth not fixing.

Not sure what this is conflicting with, but http://mxr.mozilla.org/l10n-mozilla1.9.2/search?string=location.accesskey&find=preferences%2Fmain.dtd&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-mozilla1.9.2 is full of "H", so if we want to fix this, an entity name change is required, sadly.

Comment 13

[Tyler Downer [He/Him]]

No, I think this has been this way for a long time. I think if we can pick it up in 4, it would be nice, but it's obviously a major issue as this was the first bug report I've seen on it.

Comment 14

[Tyler Downer [He/Him]]

Obvious isn't a major issue I mean. minor differences

Comment 15

[Dietrich Ayala (:dietrich)]

not a regression, and clearly no major complaints, so not blocking on this. will take the patch though, thanks for making it.

Comment 16

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/38f96d215ccb

Comment 17

[Tyler Downer [He/Him]]

v. with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100920 Firefox/4.0b7pre