Last Comment Bug 557133 - Conflict between Home Page and Help access keys (both H)
: Conflict between Home Page and Help access keys (both H)
Status: VERIFIED FIXED
[strings]
:
Product: Firefox
Classification: Client Software
Component: Keyboard Navigation (show other bugs)
: Trunk
: x86 Windows 7
: -- minor (vote)
: Firefox 4.0b7
Assigned To: Tyler Downer [:Tyler]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-04 12:54 PDT by Gids Goldberg
Modified: 2010-09-20 11:59 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
-


Attachments
screenshot of general options tab (54.34 KB, image/png)
2010-04-04 12:54 PDT, Gids Goldberg
no flags Details
Patch v1 (1.08 KB, patch)
2010-04-04 15:14 PDT, Tyler Downer [:Tyler]
no flags Details | Diff | Splinter Review
Patch v2 (2.40 KB, patch)
2010-09-15 21:52 PDT, Tyler Downer [:Tyler]
dietrich: review+
l10n: feedback+
dietrich: approval2.0+
Details | Diff | Splinter Review

Description Gids Goldberg 2010-04-04 12:54:44 PDT
Created attachment 436943 [details]
screenshot of general options tab

On the General options tab, the Home page and Help options both appear in the UI to have the same access key 'H'. 

Steps to Reproduce
------------------
Tools > Options > General Tab
Try to access Home Page field using access key (Alt + H)

Actual Results
---------------
Home Page and Help both share the same access key.
Focus is given to the Help button.

Expected Results
----------------
Help and Home Page should have different access keys.
Home Page access key should give focus to Home Page URL field.


Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100404 Minefield/3.7a4pre
Comment 1 Tyler Downer [:Tyler] 2010-04-04 14:02:24 PDT
Maybe should change it to P.
Comment 2 Tyler Downer [:Tyler] 2010-04-04 15:14:50 PDT
Created attachment 436952 [details] [diff] [review]
Patch v1

Change accesskey to P, which does not seem like it is used.
Comment 3 Robert Strong [:rstrong] (use needinfo to contact me) 2010-04-05 13:26:21 PDT
Comment on attachment 436952 [details] [diff] [review]
Patch v1

My review queue is a tad long with the extension manager rewrite so I'm pushing this over to Dietrich.

btw: we typically change the entity name unless l10n approves not changing the entity name.
Comment 4 Dietrich Ayala (:dietrich) 2010-04-13 22:56:03 PDT
Comment on attachment 436952 [details] [diff] [review]
Patch v1

Thanks Tyler! 1) I'd prefer a letter that's in the word, if possible, and 2) check to see if you need to change the entity name, as Rob said. Could either post to the l10n newsgroup or ask l10n@mozilla.com for first-review.
Comment 5 Tyler Downer [:Tyler] 2010-04-13 23:01:02 PDT
Ah, so the P in Page won't work? Alright, I'll do that soon, finals coming up ;)
Comment 6 Tyler Downer [:Tyler] 2010-06-16 22:49:40 PDT
dietrich, ping.
Before I ask l10n , will the "p" in page work?
Comment 7 Tyler Downer [:Tyler] 2010-09-15 21:29:47 PDT
Possible blocking 4 as this pretty much makes it impossible to navigate to either Home page or Help in the options window. I know string freeze is tonight...
Comment 8 Dietrich Ayala (:dietrich) 2010-09-15 21:39:18 PDT
P sounds fine to me, but the l10n people will have higher quality feedback. Create a new patch with P and the changed entity name (and changed where used) and ask feedback? from l10n@mozilla.com.
Comment 9 Dietrich Ayala (:dietrich) 2010-09-15 21:41:28 PDT
(In reply to comment #7)
> Possible blocking 4 as this pretty much makes it impossible to navigate to
> either Home page or Help in the options window. 

Can you elaborate? If we have conflicting access keys, you can't navigate to either?
Comment 10 Tyler Downer [:Tyler] 2010-09-15 21:43:48 PDT
No, you can't. Pressing Alt + H currently in the Options window does nothing, while pressing alt + S for example highlights "When Firefox starts:" So, essentially Home Page and Help are inaccessible
Comment 11 Tyler Downer [:Tyler] 2010-09-15 21:52:45 PDT
Created attachment 475747 [details] [diff] [review]
Patch v2
Comment 12 Axel Hecht [:Pike] 2010-09-15 22:14:13 PDT
Comment on attachment 475747 [details] [diff] [review]
Patch v2

This doesn't seem to be a regression, right?

Not sure if it's worth fixing at this point, though I'm also not sure if it's worth not fixing.

Not sure what this is conflicting with, but http://mxr.mozilla.org/l10n-mozilla1.9.2/search?string=location.accesskey&find=preferences%2Fmain.dtd&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-mozilla1.9.2 is full of "H", so if we want to fix this, an entity name change is required, sadly.
Comment 13 Tyler Downer [:Tyler] 2010-09-15 22:17:12 PDT
No, I think this has been this way for a long time. I think if we can pick it up in 4, it would be nice, but it's obviously a major issue as this was the first bug report I've seen on it.
Comment 14 Tyler Downer [:Tyler] 2010-09-15 22:26:33 PDT
Obvious isn't a major issue I mean. minor differences
Comment 15 Dietrich Ayala (:dietrich) 2010-09-15 22:44:44 PDT
not a regression, and clearly no major complaints, so not blocking on this. will take the patch though, thanks for making it.
Comment 16 Dão Gottwald [:dao] 2010-09-16 04:28:43 PDT
http://hg.mozilla.org/mozilla-central/rev/38f96d215ccb
Comment 17 Tyler Downer [:Tyler] 2010-09-20 11:59:25 PDT
v. with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100920 Firefox/4.0b7pre

Note You need to log in before you can comment on or make changes to this bug.