Closed Bug 557133 Opened 11 years ago Closed 11 years ago

Conflict between Home Page and Help access keys (both H)

Categories

(Firefox :: Keyboard Navigation, defect)

x86
Windows 7
defect
Not set
minor

Tracking

()

VERIFIED FIXED
Firefox 4.0b7
Tracking Status
blocking2.0 --- -

People

(Reporter: gidsgoldberg, Assigned: tdowner)

Details

(Whiteboard: [strings])

Attachments

(2 files, 1 obsolete file)

On the General options tab, the Home page and Help options both appear in the UI to have the same access key 'H'. 

Steps to Reproduce
------------------
Tools > Options > General Tab
Try to access Home Page field using access key (Alt + H)

Actual Results
---------------
Home Page and Help both share the same access key.
Focus is given to the Help button.

Expected Results
----------------
Help and Home Page should have different access keys.
Home Page access key should give focus to Home Page URL field.


Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100404 Minefield/3.7a4pre
Maybe should change it to P.
Attached patch Patch v1 (obsolete) — Splinter Review
Change accesskey to P, which does not seem like it is used.
Assignee: nobody → tyler.downer
Status: NEW → ASSIGNED
Attachment #436952 - Flags: review?(robert.bugzilla)
Comment on attachment 436952 [details] [diff] [review]
Patch v1

My review queue is a tad long with the extension manager rewrite so I'm pushing this over to Dietrich.

btw: we typically change the entity name unless l10n approves not changing the entity name.
Attachment #436952 - Flags: review?(robert.bugzilla) → review?(dietrich)
Severity: normal → minor
Attachment #436952 - Flags: review?(dietrich)
Comment on attachment 436952 [details] [diff] [review]
Patch v1

Thanks Tyler! 1) I'd prefer a letter that's in the word, if possible, and 2) check to see if you need to change the entity name, as Rob said. Could either post to the l10n newsgroup or ask l10n@mozilla.com for first-review.
Ah, so the P in Page won't work? Alright, I'll do that soon, finals coming up ;)
dietrich, ping.
Before I ask l10n , will the "p" in page work?
Possible blocking 4 as this pretty much makes it impossible to navigate to either Home page or Help in the options window. I know string freeze is tonight...
blocking2.0: --- → ?
P sounds fine to me, but the l10n people will have higher quality feedback. Create a new patch with P and the changed entity name (and changed where used) and ask feedback? from l10n@mozilla.com.
(In reply to comment #7)
> Possible blocking 4 as this pretty much makes it impossible to navigate to
> either Home page or Help in the options window. 

Can you elaborate? If we have conflicting access keys, you can't navigate to either?
No, you can't. Pressing Alt + H currently in the Options window does nothing, while pressing alt + S for example highlights "When Firefox starts:" So, essentially Home Page and Help are inaccessible
Attached patch Patch v2Splinter Review
Attachment #436952 - Attachment is obsolete: true
Attachment #475747 - Flags: feedback?(l10n)
Comment on attachment 475747 [details] [diff] [review]
Patch v2

This doesn't seem to be a regression, right?

Not sure if it's worth fixing at this point, though I'm also not sure if it's worth not fixing.

Not sure what this is conflicting with, but http://mxr.mozilla.org/l10n-mozilla1.9.2/search?string=location.accesskey&find=preferences%2Fmain.dtd&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-mozilla1.9.2 is full of "H", so if we want to fix this, an entity name change is required, sadly.
Attachment #475747 - Flags: feedback?(l10n) → feedback+
Attachment #475747 - Flags: ui-review?(beltzner)
Attachment #475747 - Flags: review?(dietrich)
No, I think this has been this way for a long time. I think if we can pick it up in 4, it would be nice, but it's obviously a major issue as this was the first bug report I've seen on it.
Whiteboard: [strings]
Obvious isn't a major issue I mean. minor differences
Attachment #475747 - Flags: review?(dietrich) → review+
not a regression, and clearly no major complaints, so not blocking on this. will take the patch though, thanks for making it.
blocking2.0: ? → -
Attachment #475747 - Flags: ui-review?(beltzner) → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/38f96d215ccb
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b7
v. with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100920 Firefox/4.0b7pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.