Closed Bug 557140 Opened 14 years ago Closed 14 years ago

TM: too easy to trigger abort on OOM

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- beta1+
blocking1.9.2 --- -
status1.9.2 --- unaffected

People

(Reporter: igor, Assigned: igor)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

v2
1.60 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review 
During a test development I accidentally wrote a script similar to:

    var array = [];
    for (var i = 0; ; ++i)
        array.push(i + 0.1);

That resulted in an abort on OOM instead of expected out-of-memory report. That seems too easy to trigger.
blocking2.0: --- → beta1+
Attached patch v1 (obsolete) — — Splinter Review 
The patch adds GC quota check and OOM reporting to the operation callback. It works for the example from the comment 0 but it needs more testing.
Assignee: general → igor
Attached patch v2 — — Splinter Review 
Here is the patch to sync with the tip changes.
Attachment #437047 - Attachment is obsolete: true
Attachment #438425 - Flags: review?(jorendorff)
Summary: TM: too easy to trigger abort on OOM? → TM: too easy to trigger abort on OOM
Comment on attachment 438425 [details] [diff] [review]
v2

Nice patch.
Attachment #438425 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/tracemonkey/rev/2425ea22570c
Whiteboard: fixed-in-tracemonkey
This is a regression from the bug 508140.
blocking1.9.2: --- → ?
Blocks: 508140
We didn't take bug 508140 on mozilla-1.9.2, so it shouldn't be affecting the branch.
blocking1.9.2: ? → -
status1.9.2: --- → unaffected
http://hg.mozilla.org/mozilla-central/rev/2425ea22570c
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: