Closed
Bug 557140
Opened 15 years ago
Closed 15 years ago
TM: too easy to trigger abort on OOM
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta1+ |
| blocking1.9.2 | --- | - |
| status1.9.2 | --- | unaffected |
People
(Reporter: igor, Assigned: igor)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
1.60 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
During a test development I accidentally wrote a script similar to:
var array = [];
for (var i = 0; ; ++i)
array.push(i + 0.1);
That resulted in an abort on OOM instead of expected out-of-memory report. That seems too easy to trigger.
|
||
Updated•15 years ago
|
blocking2.0: --- → beta1+
|
Assignee | |
Comment 1•15 years ago
|
||
The patch adds GC quota check and OOM reporting to the operation callback. It works for the example from the comment 0 but it needs more testing.
Assignee: general → igor
|
|
Assignee | |
Comment 2•15 years ago
|
||
Here is the patch to sync with the tip changes.
Attachment #437047 -
Attachment is obsolete: true
Attachment #438425 -
Flags: review?(jorendorff)
|
|
Assignee | |
Updated•15 years ago
|
Summary: TM: too easy to trigger abort on OOM? → TM: too easy to trigger abort on OOM
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 438425 [details] [diff] [review]
v2
Nice patch.
Attachment #438425 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Comment 6•15 years ago
|
||
We didn't take bug 508140 on mozilla-1.9.2, so it shouldn't be affecting the branch.
blocking1.9.2: ? → -
status1.9.2:
--- → unaffected
|
|
||
Comment 7•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•