Closed Bug 557154 Opened 10 years ago Closed 10 years ago

useless aRuleWalker null check

Categories

(Core :: CSS Parsing and Computation, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.3a4

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
nsAttrAndChildArray::WalkMappedAttributeStyleRules has a useless null check of aRuleWalker; rule walkers are (1) stack-allocated and (2) the whole point of calling the function is "I have a rule walker, tell it what rules are matched".

I noticed this while working on something else and stuck the patch in my patch queue; I've been running with it for a while.
Attachment #436960 - Flags: review?(bzbarsky)
Comment on attachment 436960 [details] [diff] [review]
patch

r=bzbarsky
Attachment #436960 - Flags: review?(bzbarsky) → review+
http://hg.mozilla.org/mozilla-central/rev/be88ae1fc675
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.